Skip to content

fix(compiler-core): handle v-memo + v-for with functional key#12014

Merged
yyx990803 merged 7 commits into
vuejs:mainfrom
linzhe141:fix-v-for-key-prop-exp
Nov 14, 2024
Merged

fix(compiler-core): handle v-memo + v-for with functional key#12014
yyx990803 merged 7 commits into
vuejs:mainfrom
linzhe141:fix-v-for-key-prop-exp

Conversation

@linzhe141

@linzhe141 linzhe141 commented Sep 24, 2024

Copy link
Copy Markdown
Member

close #12013

@github-actions

github-actions Bot commented Sep 24, 2024 •
edited
Loading

Copy link
Copy Markdown

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB 38 kB 34.2 kB
vue.global.prod.js 160 kB 58 kB 51.5 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49 kB 18.9 kB 17.2 kB
createApp 55.6 kB 21.4 kB 19.6 kB
createSSRApp 59.6 kB 23.1 kB 21 kB
defineCustomElement 60.4 kB 22.9 kB 20.9 kB
overall 69.3 kB 26.5 kB 24 kB

@pkg-pr-new

pkg-pr-new Bot commented Sep 24, 2024 •
edited
Loading

Copy link
Copy Markdown

Open in Stackblitz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12014

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12014

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12014

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12014

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12014

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12014

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12014

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12014

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12014

vue

pnpm add https://pkg.pr.new/vue@12014

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12014

commit: b709510

@linzhe141 linzhe141 marked this pull request as draft September 24, 2024 02:05
@linzhe141 linzhe141 marked this pull request as ready for review September 24, 2024 03:14
@edison1105 edison1105 changed the title fix(compiler-core): process the keyProp expression fix(compiler-core): handle v-memo + v-for with functional key Sep 24, 2024
@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: compiler 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Sep 24, 2024
@yyx990803 yyx990803 merged commit 99009ee into vuejs:main Nov 14, 2024
noootwo pushed a commit to noootwo/core that referenced this pull request Nov 15, 2024
@linzhe141 @noootwo
fix(compiler-core): handle v-memo + v-for with functional key (vuejs#…
d831090 
…12014)

close vuejs#12013
@linzhe141 linzhe141 deleted the fix-v-for-key-prop-exp branch November 19, 2024 03:32
abdullah-wn pushed a commit to Lazy-work/vue that referenced this pull request Jan 4, 2025
@linzhe141 @abdullah-wn
fix(compiler-core): handle v-memo + v-for with functional key (vuejs#…
26e5bad 
…12014)

close vuejs#12013
@rsauget rsauget mentioned this pull request May 19, 2026
Closed
@adnesvetaev adnesvetaev mentioned this pull request Jun 4, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope: compiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't use instance method as a v-for key when using v-memo

3 participants

@linzhe141 @yyx990803 @edison1105