Skip to content

fix(runtime-vapor): handle prop when vapor renders vdom component#14027

Closed
LittleSound wants to merge 2 commits intovuejs:minorfrom
LittleSound:fix/vapor-handle-prop-when-vapor-renders-vdom-component
Closed

fix(runtime-vapor): handle prop when vapor renders vdom component#14027
LittleSound wants to merge 2 commits intovuejs:minorfrom
LittleSound:fix/vapor-handle-prop-when-vapor-renders-vdom-component

Conversation

@LittleSound
Copy link
Copy Markdown
Member

@LittleSound LittleSound commented Oct 28, 2025 •
edited
Loading 

<template vapor>
  <div>
    <VirtualDomComp class="foo" />
  </div>
</template>
TypeError: Cannot redefine property: class

Playground

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Oct 28, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Oct 28, 2025 •
edited
Loading

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@14027

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@14027

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@14027

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@14027

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@14027

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@14027

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@14027

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@14027

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@14027

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@14027

@vue/shared

npm i https://pkg.pr.new/@vue/shared@14027

vue

npm i https://pkg.pr.new/vue@14027

@vue/compat

npm i https://pkg.pr.new/@vue/compat@14027

commit: 3eb49f5

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 28, 2025

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84.8 kB 30 kB 26.5 kB
runtime-dom.global.prod.js 106 kB 39.8 kB 35.8 kB
vue.global.prod.js 164 kB 60 kB 53.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.8 kB 18.7 kB 17.1 kB
createApp 56.6 kB 21.8 kB 19.9 kB
createApp + vaporInteropPlugin 89.3 kB (+28 B) 33.4 kB (+9 B) 30.3 kB (+60 B)
createVaporApp 33.1 kB 12.7 kB 11.6 kB
createSSRApp 60.9 kB 23.6 kB 21.5 kB
defineCustomElement 62 kB 23.4 kB 21.4 kB
overall 71.6 kB 27.2 kB 24.7 kB

@LittleSound
Copy link
Copy Markdown
Member Author

LittleSound commented Oct 28, 2025

duplicate of #13382

@LittleSound LittleSound reopened this Oct 28, 2025
@edison1105 edison1105 added version: minor scope: vapor related to vapor mode labels Nov 4, 2025
@edison1105 edison1105 moved this to Vapor in Next Minor Nov 4, 2025
edison1105
edison1105 reviewed Nov 6, 2025
View reviewed changes
packages/runtime-vapor/src/componentProps.ts
export const rawPropsProxyHandlers: ProxyHandler<RawProps> = {
get: getAttrFromRawProps,
get(target, key) {
if (key === ReactiveFlags.RAW) return target
Copy link
Copy Markdown
Member

@edison1105 edison1105 Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here are too broad. The actual bug scenario is clear and only exists when passing vapor props to createVNode. I think the changes in #13382 would be safer.

edison1105 added a commit that referenced this pull request Nov 6, 2025
@edison1105
fix(runtime-vapor): pass plain object props to createVNode during vdo…
6c50e20 
…m interop (#13382)

close #14027
@edison1105 edison1105 closed this Nov 6, 2025
@github-project-automation github-project-automation bot moved this from Vapor to Done in Next Minor Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edison1105 edison1105 edison1105 left review comments

Assignees

No one assigned

Labels

scope: vapor related to vapor mode version: minor

Projects

Next Minor
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LittleSound @edison1105