Skip to content

fix(runtime-vapor): pass plain object props to createVNode during vdom interop#13382

Merged
edison1105 merged 3 commits intominorfrom
edison/fix/vdomInteropWithProps
Nov 6, 2025
Merged

fix(runtime-vapor): pass plain object props to createVNode during vdom interop#13382
edison1105 merged 3 commits intominorfrom
edison/fix/vdomInteropWithProps

Conversation

@edison1105
Copy link
Copy Markdown
Member

@edison1105 edison1105 commented May 26, 2025 •
edited
Loading

Playground with this PR

@netlify
Copy link
Copy Markdown

netlify bot commented May 26, 2025 •
edited
Loading

✅ Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 398c16f
🔍 Latest deploy log https://app.netlify.com/projects/vapor-repl/deploys/683416aca51e300008921f70
😎 Deploy Preview https://deploy-preview-13382--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented May 26, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/fix/vdomInteropWithProps

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented May 26, 2025 •
edited
Loading

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13382

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13382

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13382

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13382

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13382

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13382

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13382

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13382

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13382

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13382

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13382

vue

npm i https://pkg.pr.new/vue@13382

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13382

commit: c89e915

@edison1105 edison1105 added the scope: vapor related to vapor mode label May 26, 2025
@edison1105 edison1105 force-pushed the edison/fix/vdomInteropWithProps branch from 9477b91 to 398c16f Compare May 26, 2025 07:22
@edison1105 edison1105 changed the title fix(vapor): special handling vapor props in vdom interop fix(runtime-vapor): special handling vapor props in vdom interop May 26, 2025
@edison1105 edison1105 changed the title fix(runtime-vapor): special handling vapor props in vdom interop fix(runtime-vapor): pass plain object props to createVNode during vdom interop May 27, 2025
edison1105
edison1105 commented Jun 20, 2025
View reviewed changes
packages/runtime-vapor/src/vdomInterop.ts
const vnode = createVNode(
component,
rawProps && new Proxy(rawProps, rawPropsProxyHandlers),
rawProps && extend({}, new Proxy(rawProps, rawPropsProxyHandlers)),
Copy link
Copy Markdown
Member Author

@edison1105 edison1105 Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass a plain object instead of a Proxy one

Copy link
Copy Markdown
Member Author

@edison1105 edison1105 Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another solution is to add a set trap to rawPropsProxyHandlers

Base automatically changed from vapor to minor July 7, 2025 00:06
@edison1105 edison1105 moved this to Vapor in Next Minor Jul 16, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 1, 2025 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84.8 kB 30 kB 26.5 kB
runtime-dom.global.prod.js 106 kB 39.8 kB 35.9 kB
vue.global.prod.js 164 kB 60 kB 53.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.8 kB 18.7 kB 17.1 kB
createApp 56.7 kB 21.8 kB 19.9 kB
createApp + vaporInteropPlugin 90.1 kB (+6 B) 33.7 kB (+3 B) 30.4 kB (+31 B)
createVaporApp 34 kB 12.9 kB 11.8 kB
createSSRApp 61 kB 23.6 kB 21.5 kB
defineCustomElement 62 kB 23.5 kB 21.4 kB
overall 71.6 kB 27.2 kB 24.8 kB

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 1, 2025

❌ Deploy Preview for vue-sfc-playground failed. Why did it fail? →

Name Link
🔨 Latest commit 79a76da
🔍 Latest deploy log https://app.netlify.com/projects/vue-sfc-playground/deploys/68b54834501b7d000776c8d9

@LittleSound LittleSound mentioned this pull request Oct 28, 2025
Closed
@edison1105 edison1105 moved this from Vapor to In Progress in Next Minor Nov 5, 2025
@edison1105 edison1105 force-pushed the edison/fix/vdomInteropWithProps branch from 0016c11 to ae09cce Compare November 6, 2025 00:45
@edison1105 edison1105 merged commit 6c50e20 into minor Nov 6, 2025
17 checks passed
@edison1105 edison1105 deleted the edison/fix/vdomInteropWithProps branch November 6, 2025 00:52
@github-project-automation github-project-automation bot moved this from In Progress to Done in Next Minor Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

scope: vapor related to vapor mode

Projects

Next Minor
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@edison1105