Skip to content

Use static IDs for controls needed by NVDA#850

Merged
vslavik merged 4 commits into
masterfrom
devel/nvda-static-ids
Aug 21, 2024
Merged

Use static IDs for controls needed by NVDA#850
vslavik merged 4 commits into
masterfrom
devel/nvda-static-ids

Conversation

@vslavik

@vslavik vslavik commented Jul 19, 2024

Copy link
Copy Markdown
Owner

This reorganizes Poedit's code to be able to a) assign static IDs safely and b) add more quickly if the need arrises.

See the relevant NVDA plugin's code here: https://github.com/nvaccess/nvda/blob/master/source/appModules/poedit.py

@LeonarddeR I'd appreciate your review if you could spare the time. Most of the changes are internal to Poedit and of little interest, the interesting bit is the static_id.h file:

  1. Is it understandable?
  2. Does it cover NVDA's needs?
  3. Can it be improved and/or is there more that you guys need?

I think it covers it (PRO_IDENTIFIER and MAIN_SPLITTER_IDENTIFIER seem to be needed just for the clever/hacky workaround for lack of static IDs), but I'm far from being 100% sure.

@vslavik vslavik linked an issue Jul 19, 2024 that may be closed by this pull request
Provide static control ids to aid in Screen Reader plugin creation #845
Closed
@vslavik vslavik mentioned this pull request Jul 19, 2024
Closed
@LeonarddeR

LeonarddeR commented Jul 19, 2024

Copy link
Copy Markdown
Contributor

@vslavik I'm really grateful for your kind work, I'm pretty sure this will cover everything we need.
Would it be possible to provide a build of this code others can test too? Preferably I'd like to prototype a poedit.py with the hardcoded control ids to test with so we're absolutely sure that this settles everything we need.

@vslavik

vslavik commented Jul 20, 2024

Copy link
Copy Markdown
Owner Author

Would it be possible to provide a build of this code others can test too?

@LeonarddeR Of course!

https://download.poedit.net/tmp/Poedit-3.5nvda-setup.exe

@LeonarddeR LeonarddeR mentioned this pull request Jul 20, 2024
Merged
10 tasks
@LeonarddeR

LeonarddeR commented Jul 20, 2024

Copy link
Copy Markdown
Contributor

I filed nvaccess/nvda#16889 and tested the build, it seems to work great up until now.

@vslavik

vslavik commented Aug 13, 2024

Copy link
Copy Markdown
Owner Author

I filed nvaccess/nvda#16889 and tested the build, it seems to work great up until now.

OK, thanks for testing, I plan to merge it in time for 3.5 (Real Soon Now™).

@LeonarddeR

LeonarddeR commented Aug 15, 2024

Copy link
Copy Markdown
Contributor

Thanks @vslavik.
Is there a due date for the release of poedit 3.5?

@vslavik

vslavik commented Aug 15, 2024

Copy link
Copy Markdown
Owner Author

@LeonarddeR Well, I wanted it to be out for a while now, so... 🤷‍♂️ This month for sure.

@vslavik vslavik merged commit 5d365cd into master Aug 21, 2024
@vslavik vslavik deleted the devel/nvda-static-ids branch August 21, 2024 14:06
seanbudd pushed a commit to nvaccess/nvda that referenced this pull request Sep 2, 2024
@LeonarddeR
Use static ids in Poedit 3.5+ (#16889)
4015f1c 
Related to vslavik/poedit#850

Summary of the issue:
The Poedit appmodule relies on some complex calculation logic to announce several pieces of information with shortcuts, e.g. translator notes/comments/warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide static control ids to aid in Screen Reader plugin creation

2 participants

@vslavik @LeonarddeR