Skip to content

Conversation

@AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Apr 23, 2025

Its currently not in use + scalar addition is slow. When upstream is resolved apache/datafusion#15809 we can start reporting it again

@AdamGS AdamGS changed the title . Stop reporting sum stats to datafusion Apr 23, 2025
@AdamGS AdamGS marked this pull request as ready for review April 23, 2025 13:26
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 23, 2025

CodSpeed Performance Report

Merging #3088 will improve performances by 14.6%

Comparing adamg/stop-reporting-sum (b4c12ad) with develop (385988b)

Summary

⚡ 1 improvements
✅ 810 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
take_map[(0.1, 1.0)] 615.1 µs 536.7 µs +14.6%

@AdamGS AdamGS merged commit 187e48c into develop Apr 23, 2025
27 checks passed
@AdamGS AdamGS deleted the adamg/stop-reporting-sum branch April 23, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merging Statistics is slow when sum statistic is present

3 participants