This repository is currently being migrated. It's locked while the migration is in progress.
Fix dataset-serialize benchmark by setting pre_buffer=False#152
Merged
austin3dickey merged 3 commits intomainfrom Oct 24, 2023
Merged
Fix dataset-serialize benchmark by setting pre_buffer=False#152austin3dickey merged 3 commits intomainfrom
austin3dickey merged 3 commits intomainfrom
Conversation
Pull Request Test Coverage Report for Build 6631563598
💛 - Coveralls |
austin3dickey
added a commit
that referenced
this pull request
Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes voltrondata-labs/arrow-benchmarks-ci#166.
This PR sets
pre_buffer=Falsewhen reading files in thedataset-serializebenchmark in order to avoid apache/arrow#38438.Once that's fixed, we can probably come back and remove this.