Skip to content

Conversation

@pifantastic
Copy link
Member

No description provided.

@Fil
Copy link

Fil commented Jun 30, 2013

works perfectly

@marktheunissen
Copy link
Member

Here's an edge case, try post the following URL:

http://www.slate.com/content/dam/slate/blogs/bad_astronomy/2012/12/best_of_2012_photos/SDO_arch.jpg.CROP.article920-large.jpg

screen shot 2013-06-30 at 11 31 51 am

However, if I post the markdown image tag, it works great:

![Space](http://www.slate.com/content/dam/slate/blogs/bad_astronomy/2012/12/best_of_2012_photos/SDO_arch.jpg.CROP.article920-large.jpg)

screen shot 2013-06-30 at 11 33 02 am

I think we should remove the linkify stuff and only support markdown format. Is that too restrictive?

@pifantastic
Copy link
Member Author

Yeah, I considered that. I'm just afraid that markdown is too complicated
for the casual user. I can never remember the syntax for links :P
On Jun 30, 2013 9:33 AM, "Mark Theunissen" notifications@github.com wrote:

Here's an edge case, try post the following URL:

http://www.slate.com/content/dam/slate/blogs/bad_astronomy/2012/12/best_of_2012_photos/SDO_arch.jpg.CROP.article920-large.jpg

[image: screen shot 2013-06-30 at 11 31 51 am]https://f.cloud.github.com/assets/453297/727546/99438a80-e1a2-11e2-835b-30485b545379.png

However, if I post the markdown image tag, it works great:

Space

[image: screen shot 2013-06-30 at 11 33 02 am]https://f.cloud.github.com/assets/453297/727548/c15fdcd0-e1a2-11e2-95fa-35b522201358.png

I think we should remove the linkify stuff and only support markdown
format. Is that too restrictive?


Reply to this email directly or view it on GitHubhttps://github.com//pull/83#issuecomment-20249969
.

@marktheunissen
Copy link
Member

Yeah. The other issue right now is that two consecutive lines are combined into one:

test line
test line two

becomes:

test line test line two

I think we need to get an implementation of Github Flavored Markdown specifically, which handles linkifying and solves the above issue.

https://help.github.com/articles/github-flavored-markdown

@marktheunissen
Copy link
Member

Another issue is that I can currently use <script> tags in a post and they aren't escaped. Security wise this is fine for people with newer browsers as Content Security Policy headers will prevent the script from executing, but we need to escape these.

* 'markdown' of https://github.com/vole/vole:
  Comments.
  Functional 'load more' button.
  Update Changelog.
  Protect against empty posts. I think we need to check for whitespace in postBoxDisabled. But oh well.
  Allow submitting a post with ctrl + enter.
  Support past and future pagination.
  Backend support for pagination. Front-end support TODO.
@Fil
Copy link

Fil commented Jun 30, 2013

Also, I noticed that a line starting with a #hashtag makes a title. Usually
it should be "hash-space title", I think. So showdown is probably not
perfect. And yes, the link shortcut for markdown is indeed ridiculously
difficult to remember.

@marktheunissen
Copy link
Member

@Fil Good catch, that should be fixed!

marktheunissen added a commit that referenced this pull request Jun 30, 2013
@marktheunissen marktheunissen merged commit a0996f1 into master Jun 30, 2013
@marktheunissen marktheunissen deleted the markdown branch June 30, 2013 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants