Skip to content

fix: require server api key in trusted auth mode#924

Merged
qin-ctx merged 1 commit intomainfrom
fix_auth_mode
Mar 24, 2026
Merged

fix: require server api key in trusted auth mode#924
qin-ctx merged 1 commit intomainfrom
fix_auth_mode

Conversation

@zhoujh01
Copy link
Copy Markdown
Collaborator

Description

Related Issue

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

@github-actions
Copy link
Copy Markdown

Failed to generate code suggestions for PR

@qin-ctx qin-ctx merged commit f9ccea0 into main Mar 24, 2026
6 checks passed
@qin-ctx qin-ctx deleted the fix_auth_mode branch March 24, 2026 09:14
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Mar 24, 2026
zeattacker pushed a commit to zeattacker/OpenViking that referenced this pull request Mar 25, 2026
Cherry-pick from upstream f9ccea0. Adds timing-safe API key validation
for trusted auth mode when root_api_key is configured.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants