fix(embedding): add dimension resolution for Ollama embedding provider#915
Merged
qin-ctx merged 1 commit intovolcengine:mainfrom Mar 24, 2026
Merged
Conversation
When using Ollama as embedding provider, get_effective_dimension() would fallback to 2048 (default) which caused inf similarity scores when the actual model dimension differs (e.g., nomic-embed-text is 768-dim). This fix: - Adds known Ollama model dimensions (nomic, mxbai, all-minilm, etc.) - Raises clear error for unknown models requiring explicit dimension - Prevents collection dimension mismatch Fixes volcengine#865 (Bug 1)
|
Failed to generate code suggestions for PR |
qin-ctx
approved these changes
Mar 24, 2026
zeattacker
pushed a commit
to zeattacker/OpenViking
that referenced
this pull request
Mar 25, 2026
volcengine#915) Cherry-pick from upstream 605431d Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #865 (Bug 1)
Problem
When using Ollama as embedding provider with models like
nomic-embed-text,get_effective_dimension()would fallback to 2048 (default). This caused:Dim: 2048infOut of range float values are not JSON compliant: infSolution
Added Ollama-specific dimension resolution in
get_effective_dimension():dimensionconfigTesting
infsimilarity scores, JSON error