fix(content): pass tenant context to reindex existence check#820
Merged
qin-ctx merged 1 commit intovolcengine:mainfrom Mar 20, 2026
Merged
fix(content): pass tenant context to reindex existence check#820qin-ctx merged 1 commit intovolcengine:mainfrom
qin-ctx merged 1 commit intovolcengine:mainfrom
Conversation
|
Failed to generate code suggestions for PR |
qin-ctx
approved these changes
Mar 20, 2026
qin-ctx
approved these changes
Mar 20, 2026
zeattacker
pushed a commit
to zeattacker/OpenViking
that referenced
this pull request
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix an issue where
/api/v1/content/reindexincorrectly returnedNOT_FOUNDfor non-default accounts.Previously, the URI existence check inside
reindexdid not use the request's tenant context, causing it to fall back to the default account. As a result, resources created under other accounts could not be reindexed.This PR ensures the existence check is executed within the correct tenant context.
Related Issue
Type of Change
Changes Made
ctxintoviking_fs.exists(...)inreindexto ensure tenant-scoped validationTesting
Reproduced the issue:
NOT_FOUNDunder non-default accounts before the fixVerified the fix:
Added unit test to assert
exists()is called with the correctctxI have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
I have tested this on the following platforms:
Checklist
Screenshots (if applicable)
N/A
Additional Notes
This bug only affects multi-tenant scenarios. Single-tenant (default account) usage remains unaffected, which made the issue less obvious without explicit cross-account testing.