Skip to content

fix(session): add commit_async for client.Session#819

Merged
qin-ctx merged 1 commit intovolcengine:mainfrom
boyweb:fix/bot-commit-memory
Mar 20, 2026
Merged

fix(session): add commit_async for client.Session#819
qin-ctx merged 1 commit intovolcengine:mainfrom
boyweb:fix/bot-commit-memory

Conversation

@boyweb
Copy link
Copy Markdown
Contributor

@boyweb boyweb commented Mar 20, 2026

Problem

When start the server in --with-bot model and trigger memory commit in ov chat, there is an error after calling the openviking_memory_commit tool.

Error committing to Viking: 'Session' object has no attribute 'commit_async'

Root Cause

In the commit 87ee875, await session.commit() has been modified to await session.commit_async(). In the openviking.client.Session, commit_async was not implemented.

Solution

commit has been implemented in the file and it is async method. Just add the commit_async in the class and call self.commit.

Test

Calling: openviking_memory_commit({"messages": [{"role": "user", "content": "......"}]})
  └─ Result: Successfully committed to session cli__default__00DF0727-DBBE-5DF0-AB0D-E33C3EC67AA1

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


chengwen.1104 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link
Copy Markdown

Failed to generate code suggestions for PR

@qin-ctx qin-ctx merged commit fde9e07 into volcengine:main Mar 20, 2026
1 of 2 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Mar 20, 2026
zeattacker pushed a commit to zeattacker/OpenViking that referenced this pull request Mar 20, 2026
Co-authored-by: chengwen.1104 <chengwen.1104@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants