fix(session): replace blocking commit() with commit_async() in bot#728
Merged
qin-ctx merged 2 commits intovolcengine:mainfrom Mar 19, 2026
Merged
Conversation
ov_server.py called session.commit() (sync, uses run_async() which blocks via t.join()) from an async context. When the bot runs in the same process as the server (--with-bot), this freezes the entire event loop, causing all HTTP endpoints to hang. Fix: use commit_async() which properly awaits async operations. Also add a RuntimeWarning to Session.commit() when called from a running event loop to catch future misuse. Fixes volcengine#527. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
MaojiaSheng
approved these changes
Mar 19, 2026
qin-ctx
approved these changes
Mar 19, 2026
|
|
chethanuk
added a commit
to chethanuk/OpenViking
that referenced
this pull request
Mar 19, 2026
- Add .pr_agent.toml with 15 repo-specific review rules derived from real bug history (PRs volcengine#505, volcengine#728, volcengine#749, volcengine#740/volcengine#745, volcengine#754, volcengine#735, volcengine#767) - Rules structured as WHEN/THEN/BECAUSE for deterministic enforcement - Add 8 custom labels (memory-pipeline, async-change, api-breaking, etc.) - Add ignore patterns for lock files, third_party, build artifacts - Enable score review, TODO scan, split-PR detection, security audit - Configure improve tool with quality threshold and extended mode - Configure describe tool with PR diagrams and semantic file types - Update workflow: ark-code-latest model, checkout step for .pr_agent.toml, move all config from inline YAML to .pr_agent.toml (single source of truth)
4 tasks
qin-ctx
pushed a commit
that referenced
this pull request
Mar 19, 2026
…#780) - Add .pr_agent.toml with 15 repo-specific review rules derived from real bug history (PRs #505, #728, #749, #740/#745, #754, #735, #767) - Rules structured as WHEN/THEN/BECAUSE for deterministic enforcement - Add 8 custom labels (memory-pipeline, async-change, api-breaking, etc.) - Add ignore patterns for lock files, third_party, build artifacts - Enable score review, TODO scan, split-PR detection, security audit - Configure improve tool with quality threshold and extended mode - Configure describe tool with PR diagrams and semantic file types - Update workflow: ark-code-latest model, checkout step for .pr_agent.toml, move all config from inline YAML to .pr_agent.toml (single source of truth)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session.commit()blocking the event loop in bot codesession.commit()withawait session.commit_async()inov_server.pyRuntimeWarningtoSession.commit()when called from a running event loop to prevent future misuseFixes #527
Root Cause
bot/vikingbot/openviking_mount/ov_server.py:426calledsession.commit()— a sync method that internally usesrun_async(), which blocks the calling thread viat.join(). When the bot runs in the same process as the server (--with-bot), this freezes the shared event loop. All HTTP endpoints become unresponsive (process alive but HTTP dead).The HTTP server's own session commit endpoint correctly uses
commit_async(), but the bot code path used the blocking sync version.Changes Made
bot/vikingbot/openviking_mount/ov_server.py:426: Changedsession.commit()→await session.commit_async()openviking/session/session.py: AddedRuntimeWarningincommit()when called from a running event loop, guiding callers to usecommit_async()insteadov_server.py(import ordering, unused import)Type of Change
Testing
Checklist