fix(docker): copy build_support/ into container image#699
Merged
Conversation
The build_support/ module is required during the Docker build for setup.py artifact builds but was missing from the COPY instructions, causing build failures. Co-Authored-By: Claude Opus 4.6
|
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
zhoujh01
approved these changes
Mar 17, 2026
ZaynJarvis
pushed a commit
to ZaynJarvis/OpenViking
that referenced
this pull request
Mar 17, 2026
…engine#699) The build_support/ module is required during the Docker build for setup.py artifact builds but was missing from the COPY instructions, causing build failures. Co-Authored-By: Claude Opus 4.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the missing
COPY build_support/ build_support/instruction to the Dockerfile so that thebuild_supportPython module is available during Docker image builds.Related Issue
N/A
Type of Change
Changes Made
COPY build_support/ build_support/to the Dockerfile, placed before the existingCOPY crates/ crates/line to maintain logical ordering of source copy instructions.Testing
Checklist
Screenshots (if applicable)
N/A
Additional Notes
The
build_support/directory containsx86_profiles.pyand other helpers used bysetup.pyduring native extension builds. Without this COPY instruction, Docker builds fail because the module cannot be imported.Generated with Claude Code