fix: windows zip path, code repo indexing, search retrieval, account id, rust cli version...#577
Merged
qin-ctx merged 12 commits intovolcengine:mainfrom Mar 15, 2026
Merged
Conversation
|
openviking seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
1 task
sponge225
suggested changes
Mar 13, 2026
Contributor
sponge225
left a comment
There was a problem hiding this comment.
测试结果
发现的问题
当前实现中 ZIP 路径缺少根目录名。
** 根本原因**:
file_path.relative_to(dir_path) 只返回相对路径，不包含目录名本身。
修改建议
def _zip_directory(self, dir_path: str) -> str:
"""Create a temporary zip file from a directory."""
dir_path = Path(dir_path)
if not dir_path.is_dir():
raise ValueError(f"Path {dir_path} is not a directory")
temp_dir = tempfile.gettempdir()
zip_path = Path(temp_dir) / f"temp_upload_{uuid.uuid4().hex}.zip"
root_name = dir_path.name # Add this line
with zipfile.ZipFile(zip_path, "w", zipfile.ZIP_DEFLATED) as zipf:
for file_path in dir_path.rglob("*"):
if file_path.is_file():
rel_path = file_path.relative_to(dir_path)
arcname = f"{root_name}/{rel_path}" # Include root directory name
arcname = arcname.replace("\\", "/")
zipf.write(file_path, arcname=arcname)
return str(zip_path)影响
- 修复 ZIP 路径结构
- 保留目录层级
- 保持 Windows 路径规范化
修改后的测试结果
Related: This fix complements the path normalization work in issue #540
qin-ctx
reviewed
Mar 13, 2026
Collaborator
Author
|
this fixed #594 |
qin-ctx
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Type of Change
Changes Made
Testing
Checklist
Screenshots (if applicable)
Additional Notes