Skip to content

fix(session): remove redundant parameters from archive call#575

Merged
zhoujh01 merged 1 commit intomainfrom
fix/write_archive_tmp
Mar 13, 2026
Merged

fix(session): remove redundant parameters from archive call#575
zhoujh01 merged 1 commit intomainfrom
fix/write_archive_tmp

Conversation

@myysy
Copy link
Copy Markdown
Collaborator

@myysy myysy commented Mar 13, 2026

The user, session_id, ctx and strict_extract_errors parameters are no longer needed in the archive call as they are either unused or handled internally

Description

Related Issue

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

@myysy
refactor(session): remove redundant parameters from archive call
02bf60b 
The user, session_id, ctx and strict_extract_errors parameters are no longer needed in the archive call as they are either unused or handled internally
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 13, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Method Signature Check

Verify that the _write_archive_to_temp method's signature has been updated to remove the parameters user, session_id, ctx, and strict_extract_errors, to avoid a TypeError when calling the method.

 
await self._write_archive_to_temp(
    temp_uri=session_temp_uri,
    index=self._compression.compression_index,
    messages=messages_to_archive,
)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 13, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@zhoujh01 zhoujh01 merged commit 09bbc65 into main Mar 13, 2026
6 checks passed
@zhoujh01 zhoujh01 deleted the fix/write_archive_tmp branch March 13, 2026 09:22
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Mar 13, 2026
qin-ctx added a commit that referenced this pull request Mar 13, 2026
@qin-ctx
Revert "refactor(session): remove redundant parameters from archive c…
6e252c0 
…all (#575)"

This reverts commit 09bbc65.
@qin-ctx qin-ctx mentioned this pull request Mar 13, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhoujh01 zhoujh01 zhoujh01 approved these changes

Assignees

No one assigned

Labels

Review effort 2/5

Projects

OpenViking project
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@myysy @zhoujh01