fix(test): resolve vendor-aliases paths from package root, not distRoot#985
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 17, 2026
Merged
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2
approved these changes
Mar 17, 2026
Merge activity
|
…ot (#985) The vendorMap in the vendor-aliases plugin was resolving @vitest/* paths relative to distRoot (dist/@vitest/browser/), producing doubled paths like dist/@vitest/browser/@vitest/browser/context.js. Use packageRoot (dist/) instead, fixing resolution for third-party imports like @storybook/addon-vitest. - Close #963 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: a one-line change in the test build-time patcher that only affects how `@vitest/*` alias paths are resolved in the injected browser plugin. > > **Overview** > Fixes the injected `vitest:vendor-aliases` plugin so its `@vitest/*` alias map resolves files from the dist *package root* (`packageRoot`/`dist/`) instead of `distRoot` (`dist/@vitest/browser/`). > > This prevents incorrect doubled paths when third-party tools import `@vitest/*` modules in browser mode. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 33c6164. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
33c6164 to
334863a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vendorMap in the vendor-aliases plugin was resolving @vitest/* paths
relative to distRoot (dist/@vitest/browser/), producing doubled paths like
dist/@vitest/browser/@vitest/browser/context.js. Use packageRoot (dist/)
instead, fixing resolution for third-party imports like @storybook/addon-vitest.
@vitest/browser/contextfrom@storybook/addon-vitestfails. #963Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Note
Low Risk
Low risk: a one-line change in the test build-time patcher that only affects how
@vitest/*alias paths are resolved in the injected browser plugin.Overview
Fixes the injected
vitest:vendor-aliasesplugin so its@vitest/*alias map resolves files from the dist package root (packageRoot/dist/) instead ofdistRoot(dist/@vitest/browser/).This prevents incorrect doubled paths when third-party tools import
@vitest/*modules in browser mode.Written by Cursor Bugbot for commit 33c6164. This will update automatically on new commits. Configure here.