refactor: move run_command to vite_command crate#309
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 15, 2025
accc41e to
d0cbf3f
Compare
d0cbf3f to
d13454f
Compare
06cf754 to
21916a3
Compare
d13454f to
04a551b
Compare
21916a3 to
1db7b58
Compare
This was referenced Nov 18, 2025
1db7b58 to
f3cb301
Compare
08cdddb to
74f5fb9
Compare
f3cb301 to
c315cb6
Compare
c315cb6 to
dbd0974
Compare
74f5fb9 to
fee0c4d
Compare
dbd0974 to
bc1410d
Compare
fee0c4d to
a79f950
Compare
bc1410d to
d258eb1
Compare
6f86bf0 to
3cf23ba
Compare
Merge activity
|
3cf23ba to
5bf1ebf
Compare
8ba34bc to
bb0f097
Compare
Brooooooklyn
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Moved
run_commandfunction fromvite_installto a dedicatedvite_commandcrate.What changed?
run_commandfunction fromvite_install/src/package_manager.rsvite_commandcrate invite_installrun_commandfromvite_commandinsteadnixdependency as it's no longer needed invite_installrun_commandfromvite_installHow to test?
add,remove,update, etc. still function properlyWhy make this change?
This refactoring improves code organization by moving the command execution functionality to a dedicated crate. This makes the code more modular and allows the command execution logic to be reused across different parts of the project without duplicating code. The
run_commandfunction is a general utility that deserves its own crate rather than being embedded in the package manager implementation.