Skip to content

fix(migrate): auto-remove esModuleInterop: false from tsconfig.json#1148

Merged
graphite-app[bot] merged 1 commit intomainfrom
auto-remove-esModuleInterop-false-on-migrate
Mar 27, 2026
Merged

fix(migrate): auto-remove esModuleInterop: false from tsconfig.json#1148
graphite-app[bot] merged 1 commit intomainfrom
auto-remove-esModuleInterop-false-on-migrate

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented Mar 26, 2026

Closes #1145

When vp migrate runs, it now scans all tsconfig*.json files and
removes "esModuleInterop": false which has been deprecated by
oxlint's tsgolint and causes lint errors with type-aware checking.

@fengmk2 Graphite App
Copy link
Copy Markdown
Member Author

fengmk2 commented Mar 26, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 mentioned this pull request Mar 26, 2026
Merged
8 tasks
@fengmk2 fengmk2 self-assigned this Mar 26, 2026
@fengmk2 fengmk2 force-pushed the auto-remove-esModuleInterop-false-on-migrate branch 3 times, most recently from 64c3b45 to 1e072a4 Compare March 26, 2026 06:58
fengmk2
fengmk2 commented Mar 26, 2026
View reviewed changes
@fengmk2 fengmk2 mentioned this pull request Mar 26, 2026
Merged
camc314
camc314 reviewed Mar 26, 2026
View reviewed changes
@fengmk2 fengmk2 force-pushed the auto-remove-esModuleInterop-false-on-migrate branch from 6734bd2 to 2f47f2d Compare March 26, 2026 14:01
@fengmk2 fengmk2 mentioned this pull request Mar 26, 2026
Merged
@fengmk2 fengmk2 force-pushed the auto-remove-esModuleInterop-false-on-migrate branch from 2f47f2d to e94c039 Compare March 26, 2026 14:10
@fengmk2 fengmk2 marked this pull request as ready for review March 27, 2026 02:01
cpojer
cpojer reviewed Mar 27, 2026
View reviewed changes
@fengmk2 fengmk2 force-pushed the auto-remove-esModuleInterop-false-on-migrate branch 4 times, most recently from e3bece6 to da92617 Compare March 27, 2026 06:25
@fengmk2 fengmk2 force-pushed the auto-remove-esModuleInterop-false-on-migrate branch from da92617 to 30d9c30 Compare March 27, 2026 06:27
@fengmk2 fengmk2 force-pushed the auto-remove-esModuleInterop-false-on-migrate branch from 30d9c30 to 013eea9 Compare March 27, 2026 06:37
@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Mar 27, 2026 •
edited
Loading

Merge activity

graphite-app bot pushed a commit that referenced this pull request Mar 27, 2026
@fengmk2
fix(migrate): auto-remove esModuleInterop: false from tsconfig.json (#…
3fd5160 
…1148)

Closes #1145

When `vp migrate` runs, it now scans all tsconfig*.json files and
removes `"esModuleInterop": false` which has been deprecated by
oxlint's tsgolint and causes lint errors with type-aware checking.
@graphite-app graphite-app bot force-pushed the auto-remove-esModuleInterop-false-on-migrate branch from 013eea9 to 3fd5160 Compare March 27, 2026 11:46
graphite-app bot pushed a commit that referenced this pull request Mar 27, 2026
@fengmk2
fix(migrate): auto-remove esModuleInterop: false from tsconfig.json (#…
9965461 
…1148)

Closes #1145

When `vp migrate` runs, it now scans all tsconfig*.json files and
removes `"esModuleInterop": false` which has been deprecated by
oxlint's tsgolint and causes lint errors with type-aware checking.
@graphite-app graphite-app bot force-pushed the auto-remove-esModuleInterop-false-on-migrate branch from 3fd5160 to 9965461 Compare March 27, 2026 11:50
@fengmk2
fix(migrate): auto-remove esModuleInterop: false from tsconfig.json (#…
749ef1d 
…1148)

Closes #1145

When `vp migrate` runs, it now scans all tsconfig*.json files and
removes `"esModuleInterop": false` which has been deprecated by
oxlint's tsgolint and causes lint errors with type-aware checking.
@fengmk2 fengmk2 force-pushed the auto-remove-esModuleInterop-false-on-migrate branch from 9965461 to 749ef1d Compare March 27, 2026 12:08
Base automatically changed from bun-pm to main March 27, 2026 12:17
@graphite-app graphite-app bot merged commit 749ef1d into main Mar 27, 2026
47 of 62 checks passed
@graphite-app graphite-app bot deleted the auto-remove-esModuleInterop-false-on-migrate branch March 27, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpojer cpojer cpojer approved these changes

@branchseer branchseer Awaiting requested review from branchseer

@camc314 camc314 Awaiting requested review from camc314

Assignees

@fengmk2 fengmk2

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

vp migrate should auto remove esModuleInterop: false from tsconfig.json

3 participants

@fengmk2 @cpojer @camc314