Skip to content

fix(config): use OxfmtConfig instead of FormatOptions for fmt types#1075

Merged
fengmk2 merged 1 commit intomainfrom
c/03-20-fix_config_use_oxfmtconfig_instead_of_formatoptions_for_fmt_types
Mar 21, 2026
Merged

fix(config): use OxfmtConfig instead of FormatOptions for fmt types#1075
fengmk2 merged 1 commit intomainfrom
c/03-20-fix_config_use_oxfmtconfig_instead_of_formatoptions_for_fmt_types

Conversation

@camc314
Copy link
Copy Markdown
Contributor

@camc314 camc314 commented Mar 20, 2026 •
edited
Loading

fixes #1073

Screenshot 2026-03-20 at 18 33 00

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 20, 2026 •
edited
Loading

✅ Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit 51ee7e8
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/69bd926ce3c5950008d01332

@camc314 camc314 marked this pull request as ready for review March 20, 2026 18:22
Copilot AI review requested due to automatic review settings March 20, 2026 18:22
@camc314 Graphite App
Copy link
Copy Markdown
Contributor Author

camc314 commented Mar 20, 2026

How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot AI reviewed Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the defineConfig typing for the fmt option so users can configure formatter options that exist in oxfmt’s config schema (notably overrides), addressing issue #1073.

Changes:

  • Switch UserConfig.fmt typing from the CLI’s FormatOptions alias to OxfmtConfig from oxfmt.
  • Remove the now-unused oxfmt-config.ts type re-export shim.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/cli/src/oxfmt-config.ts Removes the obsolete type re-export shim for FormatOptions/related types.
packages/cli/src/index.ts Updates the fmt option type in the public UserConfig module augmentation to OxfmtConfig.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@camc314 camc314 force-pushed the c/03-20-fix_config_use_oxfmtconfig_instead_of_formatoptions_for_fmt_types branch from 9ad57d5 to 51ee7e8 Compare March 20, 2026 18:31
fengmk2
fengmk2 approved these changes Mar 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camc314 Welcome!

@fengmk2 fengmk2 merged commit 78cb0e2 into main Mar 21, 2026
23 checks passed
@fengmk2 fengmk2 deleted the c/03-20-fix_config_use_oxfmtconfig_instead_of_formatoptions_for_fmt_types branch March 21, 2026 01:21
@leaysgur leaysgur mentioned this pull request Mar 24, 2026
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@fengmk2 fengmk2 fengmk2 approved these changes

Assignees

@fengmk2 fengmk2

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

defineConfig fmt option cannot define overrides

3 participants

@camc314 @fengmk2