fix: update resolution logic for vp create to match npm-init#1041
Merged
fengmk2 merged 3 commits intovoidzero-dev:mainfrom Mar 19, 2026
Merged
fix: update resolution logic for vp create to match npm-init#1041fengmk2 merged 3 commits intovoidzero-dev:mainfrom
vp create to match npm-init#1041fengmk2 merged 3 commits intovoidzero-dev:mainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b357d54575
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cpojer
approved these changes
Mar 19, 2026
vp create to match npm-initvp create to match npm-init
fengmk2
approved these changes
Mar 19, 2026
Member
|
@rrdelaney Thanks! |
TheAlexLichter
pushed a commit
that referenced
this pull request
Mar 19, 2026
Updates the resolution logic of `vp create` to match the logic from [`npm-init`](https://docs.npmjs.com/cli/v11/commands/npm-init), specifically around scoped names without a package. With `npm create` and `pnpm create`, scoped named resolve to `@scope/create`. Ran into this trying to run `vp create @scope` and got hit with a confusing error message, so figured I'd just upstream a fix! --------- Co-authored-by: MK (fengmk2) <fengmk2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the resolution logic of
vp createto match the logic fromnpm-init, specifically around scoped names without a package. Withnpm createandpnpm create, scoped named resolve to@scope/create.Ran into this trying to run
vp create @scopeand got hit with a confusing error message, so figured I'd just upstream a fix!