refactor(config): auto-update agent instructions, never create new files#1027
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 19, 2026
Merged
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Author
|
|
2 tasks
Member
|
It's best not to create any new agent files automatically, but when Then it would be:
This behavior should be the same if it is run via What do you think about this approach? |
Member
Author
|
@cpojer Ok, I'll improve it following this logic. |
Member
Author
|
@cpojer changed |
fengmk2
commented
Mar 19, 2026
cpojer
approved these changes
Mar 19, 2026
Merge activity
|
…les (#1027) ## Summary - `vp config` no longer creates new agent files or prompts for agent selection - Silently updates existing files that contain Vite+ markers (`<!--VITE PLUS START-->`) when content is outdated - Same behavior for `prepare` lifecycle, interactive, and non-interactive modes - Skipped with `--hooks-only` - Delete `config/agent.ts` and its tests (superseded by shared `utils/agent.ts`) ## Behavior | Scenario | Action | |----------|--------| | No agent files | No writes | | Agent files exist, no Vite+ markers | No writes | | Vite+ markers, content up to date | No writes | | Vite+ markers, content outdated | Update marked section silently | | `--hooks-only` | Skip agent update | ## Test plan - [x] `pnpm -F vite-plus snap-test-global command-config` — all 9 tests pass - [x] `pnpm -F vite-plus snap-test` — all tests pass - [x] New snap test: `command-config-update-agents` — verifies outdated markers are updated, user content preserved - [x] New snap test: `command-config-no-agent-writes` — verifies no writes when no markers, no new files created
6644144 to
0e9d243
Compare
TheAlexLichter
pushed a commit
that referenced
this pull request
Mar 19, 2026
…les (#1027) ## Summary - `vp config` no longer creates new agent files or prompts for agent selection - Silently updates existing files that contain Vite+ markers (`<!--VITE PLUS START-->`) when content is outdated - Same behavior for `prepare` lifecycle, interactive, and non-interactive modes - Skipped with `--hooks-only` - Delete `config/agent.ts` and its tests (superseded by shared `utils/agent.ts`) ## Behavior | Scenario | Action | |----------|--------| | No agent files | No writes | | Agent files exist, no Vite+ markers | No writes | | Vite+ markers, content up to date | No writes | | Vite+ markers, content outdated | Update marked section silently | | `--hooks-only` | Skip agent update | ## Test plan - [x] `pnpm -F vite-plus snap-test-global command-config` — all 9 tests pass - [x] `pnpm -F vite-plus snap-test` — all tests pass - [x] New snap test: `command-config-update-agents` — verifies outdated markers are updated, user content preserved - [x] New snap test: `command-config-no-agent-writes` — verifies no writes when no markers, no new files created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vp configno longer creates new agent files or prompts for agent selection<!--VITE PLUS START-->) when content is outdatedpreparelifecycle, interactive, and non-interactive modes--hooks-onlyconfig/agent.tsand its tests (superseded by sharedutils/agent.ts)Behavior
--hooks-onlyTest plan
pnpm -F vite-plus snap-test-global command-config— all 9 tests passpnpm -F vite-plus snap-test— all tests passcommand-config-update-agents— verifies outdated markers are updated, user content preservedcommand-config-no-agent-writes— verifies no writes when no markers, no new files created