fix(cli): use jsonc-parser for vscode settings#1003
Merged
fengmk2 merged 7 commits intovoidzero-dev:mainfrom Mar 19, 2026
Merged
fix(cli): use jsonc-parser for vscode settings#1003fengmk2 merged 7 commits intovoidzero-dev:mainfrom
fengmk2 merged 7 commits intovoidzero-dev:mainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
fengmk2
reviewed
Mar 18, 2026
73caf1a to
8f1b136
Compare
fengmk2
approved these changes
Mar 18, 2026
TheAlexLichter
pushed a commit
that referenced
this pull request
Mar 19, 2026
Close #1002 Use `jsonc-parser` as underlying parser for vscode setting migration. This approach is temporary because it won't keep comments in the file. Now it is added in `dependencies`, I am not sure whether `devDependencies` is better in this project. --------- Co-authored-by: MK (fengmk2) <fengmk2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1002
Use
jsonc-parseras underlying parser for vscode setting migration. This approach is temporary because it won't keep comments in the file.Now it is added in
dependencies, I am not sure whetherdevDependenciesis better in this project.