Skip to content

split "installation" logic from "bubblewrap" logic#42

Merged
vn971 merged 2 commits intomasterfrom
split-install-bubblewrap
Aug 16, 2019
Merged

split "installation" logic from "bubblewrap" logic#42
vn971 merged 2 commits intomasterfrom
split-install-bubblewrap

Conversation

@vn971
Copy link
Owner

@vn971 vn971 commented Aug 13, 2019

This is a preparation to fix issue #1, similar to the already existing PR #37.

@vn971 vn971 requested a review from Morganamilo August 13, 2019 16:47
@vn971
Copy link
Owner Author

vn971 commented Aug 13, 2019

@Morganamilo this just moves a few methods from wrapper.rs to action_install.rs, and deduplicates code related to Alpm by moving one function to pacman.rs.

If you want, you can just accept it lightly or skip.

@vn971
Copy link
Owner Author

vn971 commented Aug 16, 2019

This is mostly a copy-paste MR, merging.

@vn971 vn971 merged commit 19add7e into master Aug 16, 2019
vn971 pushed a commit that referenced this pull request Aug 16, 2019
* stop ever relying on current dir, current environment etc. This opens possibility for future concurrent workflow.

* add logging

* stop enforcing of target/ being the PKGDEST.
Use more flexible by-file tar review.

* resolve dependencies via RAUR library instead of relying on .SRCINFO-s

* add a separate `shellcheck` command for RUA, with built-in handling of PKGBUILD variables

* move all `include_bytes!` macros to one place

fixes GH-1, fixes GH-41, replaces GH-37, supersedes GH-42.
@vn971 vn971 deleted the split-install-bubblewrap branch August 18, 2019 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant