for azureDisk restores, update the diskURI in addition to diskName#89
Merged
ncdc merged 1 commit intovmware-tanzu:masterfrom Sep 14, 2017
Merged
for azureDisk restores, update the diskURI in addition to diskName#89ncdc merged 1 commit intovmware-tanzu:masterfrom
ncdc merged 1 commit intovmware-tanzu:masterfrom
Conversation
…ew diskName Signed-off-by: Steve Kriss <steve@heptio.com>
8031b80 to
acb3bab
Compare
davecheney
approved these changes
Sep 14, 2017
alromeros
pushed a commit
to alromeros/velero
that referenced
this pull request
Oct 25, 2024
Bumps [k8s.io/klog/v2](https://github.com/kubernetes/klog) from 2.4.0 to 2.80.1. - [Release notes](https://github.com/kubernetes/klog/releases) - [Changelog](https://github.com/kubernetes/klog/blob/main/RELEASE.md) - [Commits](kubernetes/klog@v2.4.0...v2.80.1) --- updated-dependencies: - dependency-name: k8s.io/klog/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kriss steve@heptio.com
@ncdc PTAL. I'm not 100% sure why I haven't seen this issue before, but it is definitely causing problems now. for azureDisk PV's, there is both a diskName and a diskURI, each of which contain the disk name. Ark was updating the former but not the latter. The Azure API is erroring if they don't both contain the restored disk's name.