Skip to content

docs: add shutdown configuration to vsphere-iso#536

Merged
tenthirtyam merged 1 commit intomainfrom
docs/add-shutdown-configuration
May 22, 2025
Merged

docs: add shutdown configuration to vsphere-iso#536
tenthirtyam merged 1 commit intomainfrom
docs/add-shutdown-configuration

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

Adds the shutdown configuration back to the vsphere-iso builder documentation.

Closes #525

@tenthirtyam tenthirtyam added this to the v2.0.0 milestone May 22, 2025
@tenthirtyam tenthirtyam self-assigned this May 22, 2025
@tenthirtyam tenthirtyam requested a review from a team as a code owner May 22, 2025 15:48
@tenthirtyam tenthirtyam added the documentation Documentation label May 22, 2025
@tenthirtyam tenthirtyam force-pushed the docs/add-shutdown-configuration branch 2 times, most recently from 40c24e1 to 6a70793 Compare May 22, 2025 16:57
Adds the shutdown configuration back to the `vsphere-iso` builder documentation.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam merged commit 06f7d5e into main May 22, 2025
14 checks passed
@tenthirtyam tenthirtyam deleted the docs/add-shutdown-configuration branch May 22, 2025 18:29
tenthirtyam added a commit that referenced this pull request May 22, 2025
Adds the shutdown configuration back to the `vsphere-iso` builder documentation.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
tenthirtyam added a commit that referenced this pull request May 22, 2025
Adds the shutdown configuration back to the `vsphere-iso` builder documentation.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@lindhe
Copy link
Copy Markdown

lindhe commented Sep 18, 2025

@tenthirtyam I can find these parameters documented in vsphere-clone but nowhere in vsphere-iso. Is the page not rebuilt for vsphere-iso?

@tenthirtyam
Copy link
Copy Markdown
Collaborator Author

It looks like the last release for v2.0.0 did not refresh in developer.hashicorp.com. I'll need to reach out to the team at HashiCorp to force it he refresh.

@tenthirtyam
Copy link
Copy Markdown
Collaborator Author

Inquiry sent to the team for a manual refresh of the developer site.

@tenthirtyam
Copy link
Copy Markdown
Collaborator Author

TL;DR

re: #536 (comment)

I tried the manual workflow to do the notification and get the following message:

go: downloading golang.org/x/sync v0.14.0
mapstructure-to-hcl2: clone.[Config]: internal error: package "context" without types was imported from "github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone"
builder/vsphere/clone/config.go:5: running "packer-sdc": exit status 1
mapstructure-to-hcl2: common.[LocationConfig]: internal error: package "fmt" without types was imported from "github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common"
builder/vsphere/common/config_location.go:5: running "packer-sdc": exit status 1
mapstructure-to-hcl2: iso.[Config]: internal error: package "context" without types was imported from "github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso"
builder/vsphere/iso/config.go:5: running "packer-sdc": exit status 1
mapstructure-to-hcl2: supervisor.[Config]: internal error: package "context" without types was imported from "github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor"
builder/vsphere/supervisor/config.go:5: running "packer-sdc": exit status 1
mapstructure-to-hcl2: vsphere.[Config]: internal error: package "fmt" without types was imported from "github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere"
post-processor/vsphere/post-processor.go:5: running "packer-sdc": exit status 1
mapstructure-to-hcl2: vsphere_template.[Config]: internal error: package "context" without types was imported from "github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template"
post-processor/vsphere-template/post-processor.go:5: running "packer-sdc": exit status 1
make: *** [GNUmakefile:31: generate] Error 1

This seems to be related to the shared action at hahsicorp/.github/workflows/notify-integration-release-via-manual.yaml. The actions/setup-go does not have the option to pick up the version of go from .go-version or go.mod.

When I run make generate on the v2.0.0 commit sha / tag the it's successful because I use the same version of Go as defined in go.mod.

  notify-release:
    needs:
      - strip-version
    runs-on: ubuntu-latest
    steps:
      - name: Checkout this repo
        uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
        with:
          ref: ${{ github.event.inputs.branch }}
      # Ensure that Docs are Compiled
      - uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
      - shell: bash
        run: make generate

I've shared this with @kp2099 to see if there's a way to generate the docs from the tag/commit hash and manually upload this to developer.hashicorp.com in the meantime and then address the shared GitHub Action.

Ryan Johnson, VMware by Broadcom

@github-actions
Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vsphere-iso: shutdown configuration documentation missing

3 participants