Skip to content

refactor: address unhandled errors#531

Merged
tenthirtyam merged 1 commit intomainfrom
refactor/address-unhandled-errors
May 21, 2025
Merged

refactor: address unhandled errors#531
tenthirtyam merged 1 commit intomainfrom
refactor/address-unhandled-errors

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@tenthirtyam tenthirtyam commented May 20, 2025

Handle errors from file operations, including closing files.

Logging as warning [WARN] ...

~/Downloads/packer-plugin-vsphere git:[refactor/address-unhandled-errors]
go fmt ./...

~/Downloads/packer-plugin-vsphere git:[refactor/address-unhandled-errors]
make build

~/Downloads/packer-plugin-vsphere git:[refactor/address-unhandled-errors]
make test
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        1.723s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       4.573s
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/utils [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       8.137s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  2.335s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   6.173s
?       github.com/hashicorp/packer-plugin-vsphere/examples/driver      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       1.610s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      2.231s
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]

@tenthirtyam tenthirtyam added this to the v2.0.0 milestone May 20, 2025
@tenthirtyam tenthirtyam requested a review from JenGoldstrich May 20, 2025 23:53
@tenthirtyam tenthirtyam self-assigned this May 20, 2025
@tenthirtyam tenthirtyam added the technical-debt Technical Debt label May 20, 2025
@tenthirtyam tenthirtyam requested a review from a team as a code owner May 20, 2025 23:53
@tenthirtyam tenthirtyam added the refactor Refactor label May 20, 2025
tenthirtyam
tenthirtyam commented May 21, 2025
View reviewed changes
JenGoldstrich
JenGoldstrich previously approved these changes May 21, 2025
View reviewed changes
@tenthirtyam
refactor: address unhandled errors
ecca05f 
Handle errors from file operations, including closing files.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the refactor/address-unhandled-errors branch from e16e145 to ecca05f Compare May 21, 2025 15:30
@tenthirtyam tenthirtyam requested a review from JenGoldstrich May 21, 2025 15:31
@tenthirtyam tenthirtyam merged commit cbd26dc into main May 21, 2025
14 checks passed
@tenthirtyam tenthirtyam deleted the refactor/address-unhandled-errors branch May 21, 2025 15:40
tenthirtyam added a commit that referenced this pull request May 22, 2025
@tenthirtyam
refactor: address unhandled errors (#531)
72fad6a 
Handle errors from file operations, including closing files.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 29, 2026

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@JenGoldstrich JenGoldstrich JenGoldstrich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tenthirtyam tenthirtyam

Labels

refactor Refactor technical-debt Technical Debt

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tenthirtyam @JenGoldstrich