refactor: replace type assertion on errors#530
Merged
tenthirtyam merged 1 commit intomainfrom May 21, 2025
Merged
Conversation
Replaces type assertion on errors with a call to `errors.As`. The preferred way for checking for a specific error type is to use the `errors.As` function from the standard library as this function traverses the chain of the wrapped errors while checking for a specific error type. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
JenGoldstrich
approved these changes
May 21, 2025
tenthirtyam
added a commit
that referenced
this pull request
May 21, 2025
Fix the type assertion on errors to use the `*object.DatastoreNoSuchDirectoryError` pointer. Follow-up to #530. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
tenthirtyam
added a commit
that referenced
this pull request
May 22, 2025
Replaces type assertion on errors with a call to `errors.As`. The preferred way for checking for a specific error type is to use the `errors.As` function from the standard library as this function traverses the chain of the wrapped errors while checking for a specific error type. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces type assertion on errors with a call to
errors.As.The preferred way for checking for a specific error type is to use the
errors.Asfunction from the standard library as this function traverses the chain of the wrapped errors while checking for a specific error type.