refactor: exported functions with unexported return types#529
Merged
tenthirtyam merged 1 commit intomainfrom May 21, 2025
Merged
refactor: exported functions with unexported return types#529tenthirtyam merged 1 commit intomainfrom
tenthirtyam merged 1 commit intomainfrom
Conversation
Export the return type for exported functions. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
JenGoldstrich
approved these changes
May 21, 2025
tenthirtyam
added a commit
that referenced
this pull request
May 22, 2025
Export the return type for exported functions. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: Export the return type for exported functions.
Refactors the naming conventions for struct types and their associated methods in the
post-processor/vsphere-templatepackage to improve consistency and align with Go naming standards. The changes involve renaming private struct types to exported ones and updating all related method signatures accordingly.stepCreateSnapshotstruct has been renamed toStepCreateSnapshot, making it an exported type. All associated methods (NewStepCreateSnapshot,Run, andCleanup) have been updated to reflect this change. [1] [2] [3] [4]stepMarkAsTemplatestruct has been renamed toStepMarkAsTemplate, making it an exported type. All associated methods (NewStepMarkAsTemplate,Run, andCleanup) have been updated to reflect this change. [1] [2] [3]