Skip to content

refactor: omit type declaration#528

Merged
tenthirtyam merged 1 commit intomainfrom
refactor/omit-type-declaration
May 21, 2025
Merged

refactor: omit type declaration#528
tenthirtyam merged 1 commit intomainfrom
refactor/omit-type-declaration

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@tenthirtyam tenthirtyam commented May 20, 2025

Removed variable type declaration inferred by the compiler.

~/Downloads/packer-plugin-vsphere git:[refactor/omit-type-declaration]
go fmt ./...

~/Downloads/packer-plugin-vsphere git:[refactor/omit-type-declaration]
make build

~/Downloads/packer-plugin-vsphere git:[refactor/omit-type-declaration]
make test
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        1.721s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       3.885s
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/utils [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       7.483s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  3.503s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   6.291s
?       github.com/hashicorp/packer-plugin-vsphere/examples/driver      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       1.790s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      2.323s
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]

~/Downloads/packer-plugin-vsphere git:[refactor/omit-type-declaration]
golangci-lint run           
0 issues:

@tenthirtyam
refactor: omit type declaration
e37dcd3 
Inferred by the compiler.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam added this to the v2.0.0 milestone May 20, 2025
@tenthirtyam tenthirtyam requested a review from JenGoldstrich May 20, 2025 23:10
@tenthirtyam tenthirtyam self-assigned this May 20, 2025
@tenthirtyam tenthirtyam requested a review from a team as a code owner May 20, 2025 23:10
@tenthirtyam tenthirtyam added technical-debt Technical Debt refactor Refactor labels May 20, 2025
@tenthirtyam tenthirtyam merged commit 8179ea8 into main May 21, 2025
14 checks passed
@tenthirtyam tenthirtyam deleted the refactor/omit-type-declaration branch May 21, 2025 15:28
tenthirtyam added a commit that referenced this pull request May 22, 2025
@tenthirtyam
refactor: omit type declaration (#528)
8d3ec5d 
Inferred by the compiler.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 29, 2026

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@JenGoldstrich JenGoldstrich JenGoldstrich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tenthirtyam tenthirtyam

Labels

refactor Refactor technical-debt Technical Debt

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tenthirtyam @JenGoldstrich