Skip to content

refactor: use nil slice declaration#527

Merged
tenthirtyam merged 1 commit intomainfrom
refactor/use-nil-slice-declaration
May 21, 2025
Merged

refactor: use nil slice declaration#527
tenthirtyam merged 1 commit intomainfrom
refactor/use-nil-slice-declaration

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

Replaces empty slice declaration with nil slice declaration.

An empty slice can be represented by nil or an empty slice literal. They are functionally equivalent — their len and cap are both zero — but the nil slice is the preferred style.

~/Downloads/packer-plugin-vsphere git:[refactor/use-nil-slice-declaration]
go fmt ./...

~/Downloads/packer-plugin-vsphere git:[refactor/use-nil-slice-declaration]
make build

~/Downloads/packer-plugin-vsphere git:[refactor/use-nil-slice-declaration]
make test
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        1.772s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       3.930s
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/utils [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       7.366s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  3.566s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   7.545s
?       github.com/hashicorp/packer-plugin-vsphere/examples/driver      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       2.964s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      3.561s
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]

@tenthirtyam tenthirtyam added this to the v2.0.0 milestone May 20, 2025
@tenthirtyam tenthirtyam requested a review from JenGoldstrich May 20, 2025 23:03
@tenthirtyam tenthirtyam self-assigned this May 20, 2025
@tenthirtyam tenthirtyam requested a review from a team as a code owner May 20, 2025 23:03
@tenthirtyam tenthirtyam added technical-debt Technical Debt refactor Refactor labels May 20, 2025
Replaces empty slice declaration with nil slice declaration.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the refactor/use-nil-slice-declaration branch from feb4b2f to fb26405 Compare May 20, 2025 23:03
@tenthirtyam tenthirtyam merged commit 1d3dc5b into main May 21, 2025
14 checks passed
@tenthirtyam tenthirtyam deleted the refactor/use-nil-slice-declaration branch May 21, 2025 15:28
tenthirtyam added a commit that referenced this pull request May 22, 2025
Replaces empty slice declaration with nil slice declaration.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@github-actions
Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

refactor Refactor technical-debt Technical Debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants