fix: configuration of additional disks#95
Conversation
Additional disks would always get configured as scsi devices regardless of disk_adapter_type This change ensures that additional disks are always configured on the same bus as the primary disk This resolves vmware#91
|
@tenthirtyam I would add the bug label instead of the enhancement label as it does not work as intended: |
|
@tenthirtyam @nywilken Hi, is there anything in particular that blocks @LIV2's pull request #95 from being merged? |
|
Both will need thoughtful reviews and testing. I'm happy to assist the maintainers with both once I'm back from sabbatical. Ryan Johnson |
|
Please give me time to pull this down and give it a test. |
nywilken
left a comment
There was a problem hiding this comment.
@LIV2 thanks again for opening up this change. I apologies as I wasn't able to prioritize this review sooner. I reviewed and validated the fix. I am able to get VMware Fusion to build as expected with the disk using the SATA bus.
==> vmware-iso.debian: Deleting unnecessary VMware files...
vmware-iso.debian: Deleting: builds/debian_aarch64/packer-debian.plist
vmware-iso.debian: Deleting: builds/debian_aarch64/packer-debian.scoreboard
vmware-iso.debian: Deleting: builds/debian_aarch64/vmware.log
==> vmware-iso.debian: Compacting all attached virtual disks...
vmware-iso.debian: Compacting virtual disk 1
vmware-iso.debian: Compacting virtual disk 2
vmware-iso.debian: Compacting virtual disk 3
vmware-iso.debian: Compacting virtual disk 4
==> vmware-iso.debian: Cleaning VMX prior to finishing up...
vmware-iso.debian: Detaching ISO from CD-ROM device sata0:1...
vmware-iso.debian: Disabling VNC server...
==> vmware-iso.debian: Skipping export of virtual machine...
Build 'vmware-iso.debian' finished after 5 minutes 42 seconds.
==> Wait completed after 5 minutes 42 seconds
==> Builds finished. The artifacts of successful builds are:
--> vmware-iso.debian: VM files in directory: builds/debian_aarch64
Additional disks would always get configured as scsi devices regardless of
disk_adapter_type.This change ensures that additional disks are always configured on the same bus as the primary disk.
Closes #91