api: Update ofvEnvelop.ToConfigSpec and configInfo.ToConfigSpec to handle nil ovfProperty userConfigurable#3911
Merged
akutz merged 1 commit intovmware:mainfrom Nov 25, 2025
Conversation
7928391 to
0a1cebc
Compare
…ndle nil ovfProperty userConfigurable When creating a VM we want to be sure that VApp properties are being configured correctly. We have seen behavior where a nil UserConfigurable field is treated as true. To mitigate this behavior, this PR updates the ToConfigSpec functions in configspec.go and helpers.go to explicitly set the value of a Property's UserConfigurable field to false if the field is nil. This will ensure that the property is correctly set to UserConfigurable: false when creating a VM. Signed-off-by: Adnan Baruni <adnan.baruni@broadcom.com>
0a1cebc to
31d4775
Compare
akutz
approved these changes
Nov 25, 2025
bryanv
added a commit
to bryanv/govmomi
that referenced
this pull request
Dec 3, 2025
This reverts commit 31d4775. The "api: Update ofvEnvelop.ToConfigSpec and configInfo.ToConfigSpec to handle nil ovfProperty userConfigurable" commit appears to have broken VM creation with VKS images. Signed-off-by: Bryan Venteicher <bryan.venteicher@broadcom.com>
akutz
added a commit
to akutz/govmomi
that referenced
this pull request
Dec 3, 2025
This reverts commit 3313eae.
akutz
added a commit
to akutz/govmomi
that referenced
this pull request
Dec 3, 2025
This reverts commit 3313eae. Signed-off-by: akutz <andrew.kutz@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When creating a VM we want to be sure that VApp properties are being configured correctly. We have seen behavior where a nil UserConfigurable field is treated as true. To mitigate this behavior, this PR updates the ToConfigSpec functions in configspec.go and helpers.go to explicitly set the value of a Property's UserConfigurable field to false if the field is nil. This will ensure that the property is correctly set to UserConfigurable: false when creating a VM.
Closes: #(issue-number)
How Has This Been Tested?
Unit tests.
Guidelines
Please read and follow the
CONTRIBUTIONguidelines of this project.