fix: Cross-platform path handling for OVF FileArchive uploads#3596
Merged
dougm merged 1 commit intovmware:mainfrom Oct 21, 2024
Merged
fix: Cross-platform path handling for OVF FileArchive uploads#3596dougm merged 1 commit intovmware:mainfrom
dougm merged 1 commit intovmware:mainfrom
Conversation
dougm
approved these changes
Oct 21, 2024
dougm
added a commit
to dougm/govmomi
that referenced
this pull request
Jan 6, 2025
- Fix regression introduced in 36ee9a1 / PR vmware#3596 - Add test for remote import.ovf Signed-off-by: Doug MacEachern <dougm@broadcom.com>
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Path handling for OVF uploads was using hardcoded path separators that did not support usage on Windows. This change handles paths in a cross-platform manner and ensures the absolute path is being used at all times.
Closes: #3555
How Has This Been Tested?
We have tested this in our own environment and confirmed it resolves the issues we were seeing with relative paths having paths prefixed on incorrectly.