Merged
Conversation
0eaa1fe to
ff84ef1
Compare
PR vmware#3007 added camelCase json tags for generated types BREAKING: This change adds camelCase (lower-case 1st character) json tags for govc types Fixes vmware#3243 Fixes vmware#3242 Fixes vmware#3241
ff84ef1 to
db5b3d8
Compare
Closed
dougm
added a commit
to dougm/govmomi
that referenced
this pull request
Feb 8, 2024
BREAKING: follow up to json tags missed in PR vmware#3007 and PR vmware#3247 Closes vmware#3318
This was referenced Feb 12, 2024
dougm
added a commit
to dougm/govmomi
that referenced
this pull request
Dec 24, 2024
PR vmware#3007 added camelCase json tags for generated types PR vmware#3247 added camelCase json tags for govc commands This change does the same for cns/types. Signed-off-by: Doug MacEachern <dougm@broadcom.com>
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #3007 added camelCase json tags for generated types BREAKING: This change adds camelCase (lower-case 1st character) json tags for govc types
Fixes #3243
Fixes #3242
Fixes #3241
Tags were added using:
% gomodifytags -w -transform camelcase -add-tags json -all -skip-unexported -file ...