Skip to content

Update list of HTML block elements + add source text to repo#702

Merged
robin850 merged 2 commits intovmg:masterfrom
momijizukamori:block-elements
Mar 11, 2021
Merged

Update list of HTML block elements + add source text to repo#702
robin850 merged 2 commits intovmg:masterfrom
momijizukamori:block-elements

Conversation

@momijizukamori
Copy link
Copy Markdown

I know

is deprecated, but it's still used fairly commonly and supported in browsers, and trying to parse it as inline HTML generates broken markup.

- Add center to list of HTML block elements
- Remove ins and del from list of block elements (see https://developer.mozilla.org/en-US/docs/Web/HTML/Inline_elements#elements )
- Add tests for these changes
- Add the text file used for generating block HTML hash to the repo.
@robin850
Copy link
Copy Markdown
Collaborator

Hello @momijizukamori,

I feel like the <center> addition is fine even though it's deprecated since a very long time ; it's up to people to avoid using it. Also, adding the file with tags to the repository is a great addition for future updates.

On the hand, I prefer not to remove <del> and <ins>. The Git history doesn't give the rationale behind their presence but it may break existing documents.

Could you bring them back please ?

Thanks for your contribution !

@momijizukamori
Copy link
Copy Markdown
Author

Yeah, fair enough! ins and del are both in the category of ones that can either be block or inline depending on their content. Went ahead and removed them and then regenerated the C code.

@robin850 robin850 merged commit 64bf9f9 into vmg:master Mar 11, 2021
@robin850
Copy link
Copy Markdown
Collaborator

Great, thank you very much ! 🎉 :-)

robin850 added a commit that referenced this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants