[FIX_FOR_VLLM_LATEST] Fix crash after the sampled_token_ids type change#575
Merged
iboiko-habana merged 1 commit intovllm-project:mainfrom Nov 17, 2025
Conversation
bb404c8 to
eaf744a
Compare
eaf744a to
8bcb291
Compare
iboiko-habana
requested changes
Nov 17, 2025
Collaborator
There was a problem hiding this comment.
Please change "not sampled_ids" to "sampled_ids is None" in vllm_gaudi/v1/worker/hpu_model_runner.py, line 3362. as it was done for gpu
for req_idx, sampled_ids in enumerate(postprocessed_sampled_token_ids[:num_reqs]):
if not sampled_ids:
continue
…list[np.ndarray] Signed-off-by: Paweł Olejniczak <polejniczakx@habana.ai>
8bcb291 to
a2dbdf5
Compare
Contributor
Author
@iboiko-habana Done |
iboiko-habana
approved these changes
Nov 17, 2025
✅ CI PassedAll checks passed successfully against the following vllm commit: |
afierka-intel
pushed a commit
to afierka-intel/vllm-gaudi
that referenced
this pull request
Nov 18, 2025
…ge (vllm-project#575) sampled_token_ids was changed from list[list[int]] to list[list[int]]: vllm-project/vllm#26368 Signed-off-by: Paweł Olejniczak <polejniczakx@habana.ai>
HolyFalafel
pushed a commit
to HolyFalafel/vllm-gaudi
that referenced
this pull request
Feb 1, 2026
…ge (vllm-project#575) sampled_token_ids was changed from list[list[int]] to list[list[int]]: vllm-project/vllm#26368 Signed-off-by: Paweł Olejniczak <polejniczakx@habana.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sampled_token_ids was changed from list[list[int]] to list[list[int]]:
vllm-project/vllm#26368