[Model Runner V2] Fix mrv2 mm lora issue#44450
Merged
Merged
Conversation
Signed-off-by: yewentao256 <zhyanwentao@126.com>
30 tasks
jeejeelee
reviewed
Jun 7, 2026
jeejeelee
left a comment
Member
There was a problem hiding this comment.
Can we enable at least one unit test for this case?
yewentao256
commented
Jun 7, 2026
yewentao256
left a comment
Member
Author
There was a problem hiding this comment.
Thanks @jeejeelee ! Done
jeejeelee
approved these changes
Jun 8, 2026
jeejeelee
left a comment
Member
There was a problem hiding this comment.
LGTM, sorry for the delayed response
ekagra-ranjan
pushed a commit
to ekagra-ranjan/vllm
that referenced
this pull request
Jun 9, 2026
Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: Ekagra Ranjan <3116519+ekagra-ranjan@users.noreply.github.com>
waqahmed-amd-fi
pushed a commit
to waqahmed-amd-fi/vllm
that referenced
this pull request
Jun 10, 2026
Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: Waqar Ahmed <waqar.ahmed@amd.com>
Saddss
pushed a commit
to Saddss/vllm
that referenced
this pull request
Jun 14, 2026
Signed-off-by: yewentao256 <zhyanwentao@126.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
VLLM_USE_V2_MODEL_RUNNER=1 pytest tests/lora/test_qwenvl.py::test_qwen3vl_vision_lora -xvsNow
========================================== 1 passed, 17 warnings in 48.89s ===========================================