[Model Runner v2] Migration from v1 to v2, with Qwen and DSv2 MOE models [3/N]#42667
Conversation
Signed-off-by: yewentao256 <zhyanwentao@126.com>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
Code Review
This pull request enables the V2 model runner for specific Mixture-of-Experts (MoE) architectures by adding 'DeepseekV2ForCausalLM' and 'Qwen2MoeForCausalLM' to the allowed architectures list. The logic in _is_default_v2_model_runner_model was refactored to allow these MoE models while maintaining the exclusion of quantized models. The test suite was also updated with new cases for DeepSeek, Qwen MoE, and PowerMoE to verify the configuration changes. I have no feedback to provide as there were no review comments to evaluate.
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
yewentao256
left a comment
There was a problem hiding this comment.
Should be ready to merge now, all CI failures not related
There was a problem hiding this comment.
Thanks @yewentao256! Let's wait to see how the current CI run completes...
And we should make sure that this doesn't go into the 0.23.0 release.
yewentao256
left a comment
There was a problem hiding this comment.
Thanks @njhill , Yes it won't, as we already cut the commit on Sunday night
|
Hi @yewentao256, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, |
yewentao256
left a comment
There was a problem hiding this comment.
buildkite/ci/pr/e2e-core-1-gpu
Has been fixed in main, no other issues found, remove the run all tests label
…els [3/N] (vllm-project#42667) Signed-off-by: yewentao256 <zhyanwentao@126.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Purpose
Make progress for #41286
Test
Covered in CI