Add structure to requirements/ directory#39024
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
Documentation preview: https://vllm--39024.org.readthedocs.build/en/39024/ |
There was a problem hiding this comment.
Code Review
This pull request reorganizes the project's requirement files by moving test-related dependencies into a new structured requirements/test/ directory. The changes include renaming and relocating CUDA, ROCm, XPU, and nightly-torch requirement files, while updating all corresponding references across CI configurations, Dockerfiles, pre-commit hooks, and documentation. I have no feedback to provide.
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
requirements/testrequirements/ directory
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
Hi @hmellor, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…quirements paths and nixl_connector imports after upstream restructuring (#1342) ## Summary Fixes two regressions introduced by recent upstream vLLM directory restructurings that break Docker builds, pre-commit hooks, and HPU unit tests. ## Changes 1. **Update requirements paths in Dockerfiles, README, docs and pre-commit config** — upstream moved `requirements/build.txt` → `requirements/build/cuda.txt` and `requirements/test.in` → `requirements/test/cuda.in` 2. **Update nixl_connector imports in HPU model runner and NIXL connectors** — upstream split monolithic `nixl_connector.py` into a `nixl/` package with sub-modules (`connector.py`, `metadata.py`, `scheduler.py`, `stats.py`, `utils.py`, `worker.py`) ## Upstream PRs that introduced these regressions - vllm-project/vllm#39024 — restructured `requirements/` directory layout (fix 1) - vllm-project/vllm#39354 — reorganized NIXL connector into its own directory (fix 2) --------- Signed-off-by: Paweł Olejniczak <pawelx.olejniczak@intel.com>
…ts (fixes vllm-project#39024) (vllm-project#39793) Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com> Signed-off-by: zengxian <xiangdong.zeng@intel.com>
…quirements paths and nixl_connector imports after upstream restructuring (vllm-project#1342) ## Summary Fixes two regressions introduced by recent upstream vLLM directory restructurings that break Docker builds, pre-commit hooks, and HPU unit tests. ## Changes 1. **Update requirements paths in Dockerfiles, README, docs and pre-commit config** — upstream moved `requirements/build.txt` → `requirements/build/cuda.txt` and `requirements/test.in` → `requirements/test/cuda.in` 2. **Update nixl_connector imports in HPU model runner and NIXL connectors** — upstream split monolithic `nixl_connector.py` into a `nixl/` package with sub-modules (`connector.py`, `metadata.py`, `scheduler.py`, `stats.py`, `utils.py`, `worker.py`) ## Upstream PRs that introduced these regressions - vllm-project/vllm#39024 — restructured `requirements/` directory layout (fix 1) - vllm-project/vllm#39354 — reorganized NIXL connector into its own directory (fix 2) --------- Signed-off-by: Paweł Olejniczak <pawelx.olejniczak@intel.com> Signed-off-by: Yeonsil Yoon <yeon.sil.yoon@intel.com>
|
I just ran into this. The documentation at https://docs.vllm.ai/en/stable/contributing/#license is now incorrect. Can you update it? |
…quirements paths and nixl_connector imports after upstream restructuring (vllm-project#1342) ## Summary Fixes two regressions introduced by recent upstream vLLM directory restructurings that break Docker builds, pre-commit hooks, and HPU unit tests. ## Changes 1. **Update requirements paths in Dockerfiles, README, docs and pre-commit config** — upstream moved `requirements/build.txt` → `requirements/build/cuda.txt` and `requirements/test.in` → `requirements/test/cuda.in` 2. **Update nixl_connector imports in HPU model runner and NIXL connectors** — upstream split monolithic `nixl_connector.py` into a `nixl/` package with sub-modules (`connector.py`, `metadata.py`, `scheduler.py`, `stats.py`, `utils.py`, `worker.py`) ## Upstream PRs that introduced these regressions - vllm-project/vllm#39024 — restructured `requirements/` directory layout (fix 1) - vllm-project/vllm#39354 — reorganized NIXL connector into its own directory (fix 2) --------- Signed-off-by: Paweł Olejniczak <pawelx.olejniczak@intel.com> Signed-off-by: bmyrcha <bartosz.myrcha@intel.com>
|
You are looking at |
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Robert Shaw <114415538+robertgshaw2-redhat@users.noreply.github.com>
…ts (fixes vllm-project#39024) (vllm-project#39793) Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Robert Shaw <114415538+robertgshaw2-redhat@users.noreply.github.com> Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
…ts (fixes vllm-project#39024) (vllm-project#39793) Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com> Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Robert Shaw <114415538+robertgshaw2-redhat@users.noreply.github.com>
…ts (fixes vllm-project#39024) (vllm-project#39793) Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Robert Shaw <114415538+robertgshaw2-redhat@users.noreply.github.com>
…ts (fixes vllm-project#39024) (vllm-project#39793) Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Robert Shaw <114415538+robertgshaw2-redhat@users.noreply.github.com>
…ts (fixes vllm-project#39024) (vllm-project#39793) Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Robert Shaw <114415538+robertgshaw2-redhat@users.noreply.github.com>
…ts (fixes vllm-project#39024) (vllm-project#39793) Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Robert Shaw <114415538+robertgshaw2-redhat@users.noreply.github.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
…ts (fixes vllm-project#39024) (vllm-project#39793) Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Currently build and test requirements live alongside the user requirements in
requirements/.This PR:
requirements/buildrequirements/testpip compilehook for XPU so that allrequirements/test/<device>.infiles are treated the sameThis should reduce noise in
requirements/and improve the consistency of depencency management across devices.