Skip to content

Add structure to requirements/ directory#39024

Merged
simon-mo merged 15 commits into
vllm-project:mainfrom
hmellor:test-requirements
Apr 10, 2026
Merged

Add structure to requirements/ directory#39024
simon-mo merged 15 commits into
vllm-project:mainfrom
hmellor:test-requirements

Conversation

@hmellor

@hmellor hmellor commented Apr 5, 2026

Copy link
Copy Markdown
Member

Currently build and test requirements live alongside the user requirements in requirements/.

This PR:

  • moves all build-only requirements files to requirements/build
  • moves all test-only requirements files to requirements/test
  • adds a pip compile hook for XPU so that all requirements/test/<device>.in files are treated the same

This should reduce noise in requirements/ and improve the consistency of depencency management across devices.

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor hmellor added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 5, 2026
@mergify

mergify Bot commented Apr 5, 2026

Copy link
Copy Markdown
Contributor

Documentation preview: https://vllm--39024.org.readthedocs.build/en/39024/

@mergify mergify Bot added documentation Improvements or additions to documentation ci/build nvidia rocm Related to AMD ROCm intel-gpu Related to Intel GPU labels Apr 5, 2026
@mergify mergify Bot added the cpu Related to CPU backends label Apr 5, 2026
@github-project-automation github-project-automation Bot moved this to Todo in AMD Apr 5, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reorganizes the project's requirement files by moving test-related dependencies into a new structured requirements/test/ directory. The changes include renaming and relocating CUDA, ROCm, XPU, and nightly-torch requirement files, while updating all corresponding references across CI configurations, Dockerfiles, pre-commit hooks, and documentation. I have no feedback to provide.

hmellor added 2 commits April 5, 2026 15:57
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor hmellor changed the title Move test requirements to requirements/test Add structure to requirements/ directory Apr 5, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@DarkLight1337 DarkLight1337 added the ready-run-all-tests Trigger CI with all tests for wide-ranging PRs label Apr 5, 2026
@mergify

mergify Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @hmellor.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase label Apr 6, 2026
hmellor added 2 commits April 6, 2026 20:02
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@mergify mergify Bot removed the needs-rebase label Apr 6, 2026
@mergify

mergify Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

Hi @hmellor, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?
mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
huydhn added a commit to pytorch/pytorch that referenced this pull request Apr 14, 2026
DarkLight1337 pushed a commit that referenced this pull request Apr 14, 2026
…ts (fixes #39024) (#39793)

Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com>
huydhn added a commit to pytorch/pytorch that referenced this pull request Apr 14, 2026
huydhn added a commit to pytorch/pytorch that referenced this pull request Apr 14, 2026
adobrzyn pushed a commit to vllm-project/vllm-gaudi that referenced this pull request Apr 14, 2026
…quirements paths and nixl_connector imports after upstream restructuring (#1342)

## Summary

Fixes two regressions introduced by recent upstream vLLM directory
restructurings that break Docker builds, pre-commit hooks, and HPU unit
tests.

## Changes

1. **Update requirements paths in Dockerfiles, README, docs and
pre-commit config** — upstream moved `requirements/build.txt` →
`requirements/build/cuda.txt` and `requirements/test.in` →
`requirements/test/cuda.in`
2. **Update nixl_connector imports in HPU model runner and NIXL
connectors** — upstream split monolithic `nixl_connector.py` into a
`nixl/` package with sub-modules (`connector.py`, `metadata.py`,
`scheduler.py`, `stats.py`, `utils.py`, `worker.py`)

## Upstream PRs that introduced these regressions

- vllm-project/vllm#39024 — restructured
`requirements/` directory layout (fix 1)
- vllm-project/vllm#39354 — reorganized NIXL
connector into its own directory (fix 2)

---------

Signed-off-by: Paweł Olejniczak <pawelx.olejniczak@intel.com>
zxd1997066 pushed a commit to zxd1997066/vllm that referenced this pull request Apr 15, 2026
…ts (fixes vllm-project#39024) (vllm-project#39793)

Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com>
Signed-off-by: zengxian <xiangdong.zeng@intel.com>
yeonsily pushed a commit to yeonsily/vllm-gaudi that referenced this pull request Apr 21, 2026
…quirements paths and nixl_connector imports after upstream restructuring (vllm-project#1342)

## Summary

Fixes two regressions introduced by recent upstream vLLM directory
restructurings that break Docker builds, pre-commit hooks, and HPU unit
tests.

## Changes

1. **Update requirements paths in Dockerfiles, README, docs and
pre-commit config** — upstream moved `requirements/build.txt` →
`requirements/build/cuda.txt` and `requirements/test.in` →
`requirements/test/cuda.in`
2. **Update nixl_connector imports in HPU model runner and NIXL
connectors** — upstream split monolithic `nixl_connector.py` into a
`nixl/` package with sub-modules (`connector.py`, `metadata.py`,
`scheduler.py`, `stats.py`, `utils.py`, `worker.py`)

## Upstream PRs that introduced these regressions

- vllm-project/vllm#39024 — restructured
`requirements/` directory layout (fix 1)
- vllm-project/vllm#39354 — reorganized NIXL
connector into its own directory (fix 2)

---------

Signed-off-by: Paweł Olejniczak <pawelx.olejniczak@intel.com>
Signed-off-by: Yeonsil Yoon <yeon.sil.yoon@intel.com>
@frgossen

Copy link
Copy Markdown
Contributor

I just ran into this. The documentation at https://docs.vllm.ai/en/stable/contributing/#license is now incorrect. Can you update it?

bmyrcha pushed a commit to bmyrcha/vllm-gaudi that referenced this pull request Apr 22, 2026
…quirements paths and nixl_connector imports after upstream restructuring (vllm-project#1342)

## Summary

Fixes two regressions introduced by recent upstream vLLM directory
restructurings that break Docker builds, pre-commit hooks, and HPU unit
tests.

## Changes

1. **Update requirements paths in Dockerfiles, README, docs and
pre-commit config** — upstream moved `requirements/build.txt` →
`requirements/build/cuda.txt` and `requirements/test.in` →
`requirements/test/cuda.in`
2. **Update nixl_connector imports in HPU model runner and NIXL
connectors** — upstream split monolithic `nixl_connector.py` into a
`nixl/` package with sub-modules (`connector.py`, `metadata.py`,
`scheduler.py`, `stats.py`, `utils.py`, `worker.py`)

## Upstream PRs that introduced these regressions

- vllm-project/vllm#39024 — restructured
`requirements/` directory layout (fix 1)
- vllm-project/vllm#39354 — reorganized NIXL
connector into its own directory (fix 2)

---------

Signed-off-by: Paweł Olejniczak <pawelx.olejniczak@intel.com>
Signed-off-by: bmyrcha <bartosz.myrcha@intel.com>
@hmellor

hmellor commented Apr 22, 2026

Copy link
Copy Markdown
Member Author

You are looking at stable docs, this PR is not in a release yet.

whk-lab pushed a commit to whk-lab/vllm that referenced this pull request Apr 23, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Robert Shaw <114415538+robertgshaw2-redhat@users.noreply.github.com>
whk-lab pushed a commit to whk-lab/vllm that referenced this pull request Apr 23, 2026
…ts (fixes vllm-project#39024) (vllm-project#39793)

Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com>
avinashsingh77 pushed a commit to avinashsingh77/vllm that referenced this pull request Apr 27, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Robert Shaw <114415538+robertgshaw2-redhat@users.noreply.github.com>
Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
avinashsingh77 pushed a commit to avinashsingh77/vllm that referenced this pull request Apr 27, 2026
…ts (fixes vllm-project#39024) (vllm-project#39793)

Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com>
Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
mystous pushed a commit to mystous/vllm_hybrid that referenced this pull request May 10, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Robert Shaw <114415538+robertgshaw2-redhat@users.noreply.github.com>
mystous pushed a commit to mystous/vllm_hybrid that referenced this pull request May 10, 2026
…ts (fixes vllm-project#39024) (vllm-project#39793)

Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Robert Shaw <114415538+robertgshaw2-redhat@users.noreply.github.com>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
…ts (fixes vllm-project#39024) (vllm-project#39793)

Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Robert Shaw <114415538+robertgshaw2-redhat@users.noreply.github.com>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
…ts (fixes vllm-project#39024) (vllm-project#39793)

Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com>
jhu960213 pushed a commit to jhu960213/vllm that referenced this pull request May 20, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Robert Shaw <114415538+robertgshaw2-redhat@users.noreply.github.com>
jhu960213 pushed a commit to jhu960213/vllm that referenced this pull request May 20, 2026
…ts (fixes vllm-project#39024) (vllm-project#39793)

Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com>
mvanhorn pushed a commit to mvanhorn/vllm that referenced this pull request Jun 4, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Robert Shaw <114415538+robertgshaw2-redhat@users.noreply.github.com>
Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
mvanhorn pushed a commit to mvanhorn/vllm that referenced this pull request Jun 4, 2026
…ts (fixes vllm-project#39024) (vllm-project#39793)

Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com>
Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build cpu Related to CPU backends documentation Improvements or additions to documentation intel-gpu Related to Intel GPU nvidia ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

8 participants