[CI] Fix test_nixl_connector#38838
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the cache_dtype parameter in the test_register_kv_caches unit test within test_nixl_connector.py, changing it from torch.bfloat16 to the string representation "bfloat16". I have no feedback to provide as there were no review comments to evaluate.
ProExpertProg
approved these changes
Apr 2, 2026
Contributor
|
@MatthewBonanni thanks! 😘 |
HenryTangDev
pushed a commit
to HenryTangMain/vllm
that referenced
this pull request
Apr 6, 2026
puririshi98
pushed a commit
to puririshi98/vllm
that referenced
this pull request
Apr 7, 2026
Signed-off-by: Rishi Puri <riship@nvidia.com>
big-yellow-duck
pushed a commit
to EmbeddedLLM/vllm
that referenced
this pull request
Apr 8, 2026
mtparet
pushed a commit
to blackfuel-ai/vllm
that referenced
this pull request
Apr 9, 2026
mystous
pushed a commit
to mystous/vllm_hybrid
that referenced
this pull request
May 10, 2026
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
jhu960213
pushed a commit
to jhu960213/vllm
that referenced
this pull request
May 20, 2026
huangyibo
pushed a commit
to huangyibo/vllm
that referenced
this pull request
May 21, 2026
huangyibo
pushed a commit
to huangyibo/vllm
that referenced
this pull request
Jun 4, 2026
mvanhorn
pushed a commit
to mvanhorn/vllm
that referenced
this pull request
Jun 4, 2026
Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes CI failure introduced by #38378. Simple type issue
Example of failure: https://buildkite.com/vllm/ci/builds/59462/steps/canvas?sid=019d4e6d-51dc-4af1-8a18-6ba674374efe&tab=output
Test Plan
V1 Core + KV + Metrics
Test Result
Should pass in CI
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.