Fix tie_word_embeddings for multimodal models in Transformers v5#33359
Merged
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly addresses an issue with tie_word_embeddings for multimodal models in Transformers v5 by propagating the setting from the main model config to the text-specific config. I've added one high-severity comment to improve the robustness of the implementation and prevent a potential AttributeError for certain multimodal models.
yewentao256
approved these changes
Jan 29, 2026
yewentao256
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the work!
PiratePai
pushed a commit
to PiratePai/epd_shm
that referenced
this pull request
Feb 3, 2026
…llm-project#33359) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Pai <416932041@qq.com>
Collaborator
|
But vLLM requires transformers<5, why do we need this change? @hmellor |
Member
Author
|
We will support v5 soon. I have been making vLLM forward compatible so that there can be a period of overlap where we support both. |
mystous
pushed a commit
to mystous/vllm_hybrid
that referenced
this pull request
May 10, 2026
…llm-project#33359) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…llm-project#33359) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…llm-project#33359) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
0826joyce
pushed a commit
to 0826joyce/vllm-serving-optimization
that referenced
this pull request
May 19, 2026
…llm-project#33359) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Transformers v5,
tie_word_embeddingsbelongs to the config of the class that can see both layers to be tied. For example:Therefore,
tie_word_embeddingsis defined inSomeVLModelForMultimodalLM's config and is not present inSomeVLModel's config. In vLLM, thelm_headbelongs to thelanguage_model, so we must ensure thattie_word_embeddingsis set in thelanguage_model's config.