Skip to content

[GLM-4.7] GLM Model support for GLM-Lite#31386

Merged
ywang96 merged 21 commits into
vllm-project:mainfrom
zRzRzRzRzRzRzR:glm
Jan 19, 2026
Merged

[GLM-4.7] GLM Model support for GLM-Lite#31386
ywang96 merged 21 commits into
vllm-project:mainfrom
zRzRzRzRzRzRzR:glm

Conversation

@zRzRzRzRzRzRzR

@zRzRzRzRzRzRzR zRzRzRzRzRzRzR commented Dec 26, 2025

Copy link
Copy Markdown
Contributor

using with transformers 5.0.0 with GLM-Lite model, transformers PR here

Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.

@mergify mergify Bot added new-model Requests to new models performance Performance-related issues labels Dec 26, 2025

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the GLM-Lite model and its MTP (Multi-Token Prediction) variant for speculative decoding. The changes include new model implementation files, updates to model registries, and modifications to benchmark configurations. The implementation appears to leverage existing patterns from models like DeepseekV2. My review has identified a critical issue in the test configuration that could lead to incorrect testing, and a high-severity type hint error in the new model implementation.

Comment thread tests/models/registry.py Outdated
Comment thread vllm/model_executor/models/glm4_moe_lite.py
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
@zRzRzRzRzRzRzR zRzRzRzRzRzRzR marked this pull request as ready for review December 27, 2025 06:18
@mergify

mergify Bot commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @zRzRzRzRzRzRzR.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase label Jan 5, 2026
@zRzRzRzRzRzRzR zRzRzRzRzRzRzR changed the title GLM Testing [GLM-4.7] GLM Model support for GLM-Lite Jan 15, 2026
Signed-off-by: Yuxuan Zhang <2448370773@qq.com>
Comment thread tests/models/registry.py Outdated
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
Comment thread tests/models/registry.py Outdated
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
@zRzRzRzRzRzRzR

Copy link
Copy Markdown
Contributor Author

like this?

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) January 17, 2026 07:47
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 17, 2026
Signed-off-by: Roger Wang <hey@rogerw.io>
Signed-off-by: Roger Wang <hey@rogerw.io>
@ywang96 ywang96 disabled auto-merge January 19, 2026 09:18
@ywang96 ywang96 merged commit 71832ba into vllm-project:main Jan 19, 2026
27 of 56 checks passed
gopalsarda pushed a commit to gopalsarda/vllm that referenced this pull request Jan 20, 2026
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
Signed-off-by: Yuxuan Zhang <2448370773@qq.com>
@zRzRzRzRzRzRzR zRzRzRzRzRzRzR deleted the glm branch January 21, 2026 05:37
mystous pushed a commit to mystous/vllm_hybrid that referenced this pull request May 10, 2026
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
Signed-off-by: Yuxuan Zhang <2448370773@qq.com>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
Signed-off-by: Yuxuan Zhang <2448370773@qq.com>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
Signed-off-by: Yuxuan Zhang <2448370773@qq.com>
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
Signed-off-by: Yuxuan Zhang <2448370773@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation new-model Requests to new models performance Performance-related issues ready ONLY add when PR is ready to merge/full CI is needed tool-calling

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants