[UX] Put CUDA attention backend selection log into one line#29337
Merged
vllm-bot merged 1 commit intovllm-project:mainfrom Nov 25, 2025
Merged
[UX] Put CUDA attention backend selection log into one line#29337vllm-bot merged 1 commit intovllm-project:mainfrom
vllm-bot merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: mgoin <mgoin64@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the logging for CUDA attention backend selection by consolidating two log messages into a single, more informative line. This is a good user experience improvement as it makes the logs more concise and easier to parse. The implementation is correct and looks good.
| selected_backend = valid_backends_priorities[selected_index][0] | ||
| logger.info( | ||
| "Using %s backend.", | ||
| "Using %s attention backend out of potential backends: %s", |
Collaborator
There was a problem hiding this comment.
Can we only do this for the first rank?
Member
Author
There was a problem hiding this comment.
Not if we keep the list. scope="local" only works with _once logs and if I try info_once I get TypeError: unhashable type: 'list'
We could extend the scope support to non-_once methods, but currently we aren't overriding those at all in vllm/logger.py
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…ject#29337) Signed-off-by: mgoin <mgoin64@gmail.com>
kitaekatt
pushed a commit
to kitaekatt/vllm
that referenced
this pull request
Dec 1, 2025
…ject#29337) Signed-off-by: mgoin <mgoin64@gmail.com>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
…ject#29337) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Before:
After:
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.