Skip to content

Scheduled removal of CompilationConfig.use_inductor#29323

Merged
hmellor merged 3 commits intovllm-project:mainfrom
hmellor:remove-use-inductor
Nov 25, 2025
Merged

Scheduled removal of CompilationConfig.use_inductor#29323
hmellor merged 3 commits intovllm-project:mainfrom
hmellor:remove-use-inductor

Conversation

@hmellor
Copy link
Copy Markdown
Member

@hmellor hmellor commented Nov 24, 2025

This field is scheduled for removal in v0.12.0, which will be the next release.

This field is scheduled for removal in v0.12.0, which will be the next release.

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully removes the deprecated CompilationConfig.use_inductor field. The changes are applied consistently across configuration, tests, and documentation. The use_inductor field is correctly replaced by the backend field, and the associated backward-compatibility logic has been cleanly removed. The updated tests ensure that the refactoring does not introduce regressions. This is a solid and well-executed cleanup.

Copy link
Copy Markdown
Collaborator

@ProExpertProg ProExpertProg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Copy Markdown
Member

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work!

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor hmellor enabled auto-merge (squash) November 25, 2025 10:47
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 25, 2025
@hmellor hmellor merged commit 51fc9e0 into vllm-project:main Nov 25, 2025
47 checks passed
@hmellor hmellor deleted the remove-use-inductor branch November 25, 2025 12:55
devpatelio pushed a commit to SumanthRH/vllm that referenced this pull request Nov 29, 2025
…9323)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
kitaekatt pushed a commit to kitaekatt/vllm that referenced this pull request Dec 1, 2025
…9323)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
dsuhinin pushed a commit to dsuhinin/vllm that referenced this pull request Jan 21, 2026
…9323)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants