Merged
Conversation
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a pre-commit issue where rope_theta and rope_scaling were used without being defined. The fix correctly replaces these with rope_parameters=config.rope_parameters when initializing indexer_rope_emb. This change is consistent with how get_rope is called elsewhere in the file and effectively resolves the F821 Undefined name errors. The fix is correct and minimal. Good job.
mgoin
approved these changes
Nov 19, 2025
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
Signed-off-by: yewentao256 <zhyanwentao@126.com>
kitaekatt
pushed a commit
to kitaekatt/vllm
that referenced
this pull request
Dec 1, 2025
Signed-off-by: yewentao256 <zhyanwentao@126.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix precommit issue introduced by #28968