[GC Debugger] Simply and improve GC Debugger Utils#29029
Merged
22quinn merged 2 commits intovllm-project:mainfrom Nov 20, 2025
Merged
[GC Debugger] Simply and improve GC Debugger Utils#2902922quinn merged 2 commits intovllm-project:mainfrom
22quinn merged 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces several valuable improvements to the GC Debugger utilities. The changes include a performance optimization to conditionally invoke gc.get_objects, reducing overhead during lightweight debugging. The freeze_gc_heap function has been simplified by replacing redundant garbage collection calls with a single, more efficient call. Additionally, the GC debugger attachment logic has been refactored and moved to the more general EngineCore class, broadening its applicability. These changes are well-implemented, correct, and enhance both the performance and the architecture of the GC debugging tools. The pull request is a solid contribution.
22quinn
approved these changes
Nov 19, 2025
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
kitaekatt
pushed a commit
to kitaekatt/vllm
that referenced
this pull request
Dec 1, 2025
Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Further improve GC Debugger.
Test Plan & Test Results
CI Signals and verify the changed locally
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.