Merged
Conversation
Signed-off-by: Nick Hill <nhill@redhat.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces colored logging, which is a great enhancement for readability. The implementation is mostly solid, adding a VLLM_LOGGING_COLOR environment variable to control the behavior (auto, always, never). A new ColoredFormatter is introduced to handle the coloring logic. I've found a minor issue in the ColoredFormatter where the coloring of file path and line number is not applied as intended, and I've provided a suggestion to fix it. Overall, a good addition.
Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Nick Hill <nhill@redhat.com>
njhill
commented
Nov 19, 2025
|
|
||
|
|
||
| def test_default_vllm_root_logger_configuration(): | ||
| def test_default_vllm_root_logger_configuration(monkeypatch): |
Member
Author
There was a problem hiding this comment.
Most of the changes in this file are just changing from using mock @patch of global vars to monkeypatch.setenv()
RunkaiTao
pushed a commit
to RunkaiTao/vllm
that referenced
this pull request
Nov 24, 2025
Signed-off-by: Nick Hill <nhill@redhat.com> Signed-off-by: Runkai Tao <rt572@physics.rutgers.edu>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
Signed-off-by: Nick Hill <nhill@redhat.com>
5 tasks
kitaekatt
pushed a commit
to kitaekatt/vllm
that referenced
this pull request
Dec 1, 2025
Signed-off-by: Nick Hill <nhill@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only takes effect when output to a terminal device.
Before
After
