Revert "[Core] Performance: Use list[np.ndarray] instead of list[list…#28773
Merged
Revert "[Core] Performance: Use list[np.ndarray] instead of list[list…#28773
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request reverts a previous commit that changed the data structure for output tokens from list[list[int]] to list[np.ndarray] for performance reasons. The changes in this PR consistently revert this change across the codebase, including test files and core logic. The modifications involve removing numpy imports, changing type hints back to list[list[int]], and adjusting the code to work with lists instead of numpy arrays (e.g., using len() instead of .shape[0], and .tolist() for conversions). The revert appears to be correct and complete.
DarkLight1337
approved these changes
Nov 15, 2025
geodavic
pushed a commit
to geodavic/vllm
that referenced
this pull request
Nov 16, 2025
vllm-project#28773) Signed-off-by: George D. Torres <gdavtor@gmail.com>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
kitaekatt
pushed a commit
to kitaekatt/vllm
that referenced
this pull request
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…[int]] for output tokens for GC optimization (#26368)"
This reverts commit 186352b.