Skip to content

[Bugfix] Fix incorrect kv cache metrics in grafana.json#27133

Merged
vllm-bot merged 2 commits intovllm-project:mainfrom
fangpings:fix_grafana
Oct 23, 2025
Merged

[Bugfix] Fix incorrect kv cache metrics in grafana.json#27133
vllm-bot merged 2 commits intovllm-project:mainfrom
fangpings:fix_grafana

Conversation

@fangpings
Copy link
Copy Markdown
Contributor

@fangpings fangpings commented Oct 17, 2025 •
edited by github-actions Bot
Loading

Purpose

Current grafana.json is using an outdated prometheus metrics name gpu_cache_usage_perc. The lastest metrics is named kv_cache_usage_perc. See here

Test Plan

Verified in my own grafana dashboard

Test Result

Before

Screenshot 2025-10-17 at 4 27 30 PM

After

Screenshot 2025-10-17 at 4 27 45 PM
Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 17, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Oct 17, 2025

Documentation preview: https://vllm--27133.org.readthedocs.build/en/27133/

@mergify mergify Bot added the documentation Improvements or additions to documentation label Oct 17, 2025
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Oct 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the grafana.json file to use the correct Prometheus metric name for GPU cache usage. The old metric name gpu_cache_usage_perc is replaced with the new metric name kv_cache_usage_perc. This change ensures that the Grafana dashboard accurately reflects the current metrics being exposed by vLLM.

Comment thread examples/online_serving/prometheus_grafana/grafana.json
@@ -852,7 +852,7 @@
"uid": "${DS_PROMETHEUS}"
},
"editorMode": "code",
"expr": "vllm:gpu_cache_usage_perc{model_name=\"$model_name\"}",
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The metric name vllm:gpu_cache_usage_perc is outdated and should be updated to vllm:kv_cache_usage_perc to align with the latest metrics. This discrepancy could lead to incorrect monitoring and alerting.

It's critical to ensure that monitoring dashboards use the correct metric names to provide accurate insights into system performance and resource utilization.

          "expr": "vllm:kv_cache_usage_perc{model_name=\"$model_name\"}"

@markmc
Copy link
Copy Markdown
Member

markmc commented Oct 20, 2025

Thank you!

Just need to fix the DCO issue:

always include Signed-off-by: Author Name authoremail@example.com in every commit message

Since you'll be making that update, would you mind also searching and replacing in examples/online_serving/dashboards/perses/ too? No need to test

fix: kv cache panel in grafana.json
f3c5ca8 
Signed-off-by: Fangping Shi <fangping_shi@apple.com>
replace deprecated metrics under pserses
8906e86 
Signed-off-by: Fangping Shi <fangping_shi@apple.com>
@fangpings
Copy link
Copy Markdown
Contributor Author

fangpings commented Oct 20, 2025

Thank you!

Just need to fix the DCO issue:

always include Signed-off-by: Author Name authoremail@example.com in every commit message

Since you'll be making that update, would you mind also searching and replacing in examples/online_serving/dashboards/perses/ too? No need to test

Thanks. I replaced occurrence under that folder too.

@markmc markmc mentioned this pull request Oct 22, 2025
Closed
@markmc markmc requested a review from DarkLight1337 October 22, 2025 18:59
@vllm-bot vllm-bot merged commit 7e09410 into vllm-project:main Oct 23, 2025
5 checks passed
usberkeley pushed a commit to usberkeley/vllm that referenced this pull request Oct 23, 2025
@fangpings @usberkeley
[Bugfix] Fix incorrect kv cache metrics in grafana.json (vllm-project…
7b301ad 
…#27133)

Signed-off-by: Fangping Shi <fangping_shi@apple.com>
Co-authored-by: Fangping Shi <fangping_shi@apple.com>
845473182 pushed a commit to raindaywhu/vllm that referenced this pull request Oct 24, 2025
Merge branch 'step_forward' of https://github.com/raindaywhu/vllm int…
6f4dbd4 
…o step_forward

* 'step_forward' of https://github.com/raindaywhu/vllm: (148 commits)
  [Model] Add MoE support for NemotronH (vllm-project#25863)
  [Metrics] [KVConnector] Add connector prefix cache hit rate stats (vllm-project#26245)
  [CI] Reorganize entrypoints tests (vllm-project#27403)
  add SLA information into comparison graph for vLLM Benchmark Suite (vllm-project#25525)
  [CI/Build] Fix AMD CI: test_cpu_gpu.py (vllm-project#27388)
  [Bugfix] Fix args settings for guided decoding args (vllm-project#27375)
  [CI/Build] Fix Prithvi plugin test (vllm-project#27393)
  [Chore] Remove duplicate `has_` functions in vllm.utils (vllm-project#27372)
  [Model] Add num_cached_tokens for PoolingRequestOutput (vllm-project#27378)
  [V1][spec decode] return logprobs for spec decoding (vllm-project#26060)
  [CORE] Support Prefix Caching with Prompt Embeds (vllm-project#27219)
  [Bugfix][Core] running queue index leakage exception (vllm-project#26754)
  [Bugfix] Fix incorrect kv cache metrics in grafana.json (vllm-project#27133)
  [Bugfix] Fix SLA tuner initialization (vllm-project#27355)
  [Bugfix] Fix deepseek-ocr multi-image inference and add `merge_by_field_config=True` with tensor schema support (vllm-project#27361)
  [MLA] Bump FlashMLA (vllm-project#27354)
  [Chore] Separate out system utilities from vllm.utils (vllm-project#27201)
  [BugFix] bugfix for Flash Attention MLA with full cuda graph IMA following pr-25490 (vllm-project#27128)
  [Feature] publisher default set zmq in kv_event config (vllm-project#26915)
  [Prefix Cache] Use LoRA name for consistent KV-cache block hashing (vllm-project#27211)
  ...
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
@fangpings @0xrushi
[Bugfix] Fix incorrect kv cache metrics in grafana.json (vllm-project…
070d17b 
…#27133)

Signed-off-by: Fangping Shi <fangping_shi@apple.com>
Co-authored-by: Fangping Shi <fangping_shi@apple.com>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
@fangpings @0xrushi
[Bugfix] Fix incorrect kv cache metrics in grafana.json (vllm-project…
b772869 
…#27133)

Signed-off-by: Fangping Shi <fangping_shi@apple.com>
Co-authored-by: Fangping Shi <fangping_shi@apple.com>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
ilmarkov pushed a commit to neuralmagic/vllm that referenced this pull request Nov 7, 2025
@fangpings @ilmarkov
[Bugfix] Fix incorrect kv cache metrics in grafana.json (vllm-project…
8100af7 
…#27133)

Signed-off-by: Fangping Shi <fangping_shi@apple.com>
Co-authored-by: Fangping Shi <fangping_shi@apple.com>
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
@fangpings @rtourgeman
[Bugfix] Fix incorrect kv cache metrics in grafana.json (vllm-project…
8895720 
…#27133)

Signed-off-by: Fangping Shi <fangping_shi@apple.com>
Co-authored-by: Fangping Shi <fangping_shi@apple.com>
devpatelio pushed a commit to SumanthRH/vllm that referenced this pull request Nov 29, 2025
@fangpings @devpatelio
[Bugfix] Fix incorrect kv cache metrics in grafana.json (vllm-project…
2b16503 
…#27133)

Signed-off-by: Fangping Shi <fangping_shi@apple.com>
Co-authored-by: Fangping Shi <fangping_shi@apple.com>
This was referenced Dec 4, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markmc markmc markmc approved these changes

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fangpings @markmc @DarkLight1337 @vllm-bot