GLM-4.5 Model Support by zRzRzRzRzRzRzR · Pull Request #20736 · vllm-project/vllm

zRzRzRzRzRzRzR · 2025-07-10T05:44:00Z

GLM-4 Update of Moe Support

Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>

github-actions · 2025-07-10T05:44:10Z

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

gemini-code-assist

Summary of Changes

Hello @zRzRzRzRzRzRzR, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive support for the GLM-4 Mixture-of-Experts (MoE) model within vLLM. It provides the full architectural implementation, including specialized MoE components, and integrates the new model into the existing benchmarking and model loading infrastructure.

Highlights

New Model Support: I've added the complete implementation for the Glm4MoeForCausalLM model architecture, enabling vLLM to support GLM-4 Mixture-of-Experts models.
Mixture-of-Experts (MoE) Implementation: The new glm4_moe.py file includes custom components like Glm4MoeTopkRouter for expert selection and Glm4MoeSparseMoeBlock to handle the specific routing and shared expert mechanisms of GLM-4's MoE architecture.
System Integration: Updates were made to the MoE benchmarking script (benchmark_moe.py) and the model registry (registry.py) to properly recognize and integrate the new Glm4MoeForCausalLM model within vLLM's ecosystem.
Weight Loading Logic: The new model implementation includes robust weight loading logic to correctly map and load parameters from HuggingFace checkpoints, covering stacked linear layers (QKV, gate/up projections) and individual expert weights.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>

gemini-code-assist

Code Review

The pull request adds support for GLM-4 MoE models to vLLM. The changes include modifying the benchmark script to include GLM-4 MoE, adding the GLM-4 MoE model to the model registry, and creating a new file for the GLM-4 MoE model architecture. There's a potential typo in the benchmark script that needs to be addressed, and the model path in the registry should be a real model name.

Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>

jeejeelee

Thank you, we also need to update the document.

zRzRzRzRzRzRzR · 2025-07-11T15:42:37Z

Thank you, we also need to update the document.

you mean supported_models.md, isnt it generate auto?

jeejeelee · 2025-07-12T08:44:02Z

Thank you, we also need to update the document.

Thank you, we also need to update the document.

you mean supported_models.md, isnt it generate auto?

Yes, we need to update manually.

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>

zRzRzRzRzRzRzR · 2025-07-13T15:57:18Z

We also have the MTP model, but if this PR meets the requirements, it can be merged first. The implementation of MTP can be proposed in a separate PR.

zchen-gitch · 2025-08-01T09:38:30Z

I run GLM-4.5-fp8 on the vllm-0.10.0 environment
raise NotImplementedError(
(VllmWorker rank=6 pid=134832) ERROR 08-01 10:13:01 [multiproc_executor.py:511] NotImplementedError: The class UnquantizedLinearMethod must implement the 'embedding' method, see UnquantizedEmbeddingMethod.

fernandaspets · 2025-08-02T21:05:53Z

Hi I get this error "transformers.models.glm4_moe.modeling_glm4_moe.Glm4MoeModel'> does not support tensor parallel yet!" on vllm 10.1 with latest transformers as of 8/2/25. When attempting -tp 2 since it wont fit on one rtx blackwell 6000 96gb

fernandaspets · 2025-08-03T06:23:56Z

I'm getting errors in vllm 10.0 and 10.1 trying AWQ, GPTQ and FP8 non work with or without tensor parallelism with my 6000 blackwell cards

Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com> Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: Lu Fang <fanglu@fb.com> Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn> Co-authored-by: Lu Fang <fanglu@fb.com> Signed-off-by: x22x22 <wadeking@qq.com>

Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com> Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: Lu Fang <fanglu@fb.com> Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn> Co-authored-by: Lu Fang <fanglu@fb.com>

cherry-pick: vllm-project@10eb24c Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com> Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: Lu Fang <fanglu@fb.com> Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn> Co-authored-by: Lu Fang <fanglu@fb.com>

Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com> Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: Lu Fang <fanglu@fb.com> Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn> Co-authored-by: Lu Fang <fanglu@fb.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>

Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com> Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: Lu Fang <fanglu@fb.com> Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn> Co-authored-by: Lu Fang <fanglu@fb.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>

cherry-pick: vllm-project@10eb24c Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com> Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: Lu Fang <fanglu@fb.com> Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn> Co-authored-by: Lu Fang <fanglu@fb.com>

Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com> Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: Lu Fang <fanglu@fb.com> Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn> Co-authored-by: Lu Fang <fanglu@fb.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>

Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com> Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: Lu Fang <fanglu@fb.com> Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn> Co-authored-by: Lu Fang <fanglu@fb.com>

init

e11b28a

Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>

zRzRzRzRzRzRzR requested review from DarkLight1337 and ywang96 as code owners July 10, 2025 05:44

gemini-code-assist Bot reviewed Jul 10, 2025

View reviewed changes

mergify Bot added the performance Performance-related issues label Jul 10, 2025

ovis aimv2 model type need changed, mark

818db59

Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>

gemini-code-assist Bot reviewed Jul 10, 2025

View reviewed changes

Comment thread benchmarks/kernels/benchmark_moe.py Outdated

Comment thread tests/models/registry.py Outdated

zRzRzRzRzRzRzR added 3 commits July 10, 2025 14:01

format

c6b8eb6

Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>

format

f406a09

Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>

use ds loading(not work)

efcff2b

mergify Bot added the new-model Requests to new models label Jul 10, 2025

zRzRzRzRzRzRzR added 8 commits July 10, 2025 18:42

update

e6ad576

Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>

update 1

d49c5bc

Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>

test

c8ad31e

Update glm4_moe.py

2440756

update

5e38b14

Update glm4_moe.py

c227471

1

9f3ab70

use ds imp

8feace6

jeejeelee reviewed Jul 11, 2025

View reviewed changes

Comment thread vllm/model_executor/models/glm4_moe.py

jeejeelee reviewed Jul 11, 2025

View reviewed changes

Comment thread vllm/transformers_utils/configs/ovis.py Outdated

zRzRzRzRzRzRzR added 2 commits July 11, 2025 22:26

Merge branch 'vllm-project:main' into glm-moe

a875d98

update and merge

12666d3

Isotr0py and others added 2 commits July 12, 2025 22:28

fix partial_rotary_factor

ffe9d62

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>

Merge branch 'vllm-project:main' into glm-moe

19de827

Update for doc

dbf1719

github-project-automation Bot moved this to Done in Tool Calling Jul 19, 2025

zRzRzRzRzRzRzR deleted the glm-moe branch July 20, 2025 03:07

zRzRzRzRzRzRzR restored the glm-moe branch July 21, 2025 13:26

zRzRzRzRzRzRzR deleted the glm-moe branch July 21, 2025 13:26

zRzRzRzRzRzRzR changed the title ~~GLM-4 Update~~ GLM-4.5 Model Support Jul 27, 2025

jacekpoplawski mentioned this pull request Jul 28, 2025

Feature Request: GLM 4.5 MoE support ggml-org/llama.cpp#14921

Closed

4 tasks

rankaiyx mentioned this pull request Jul 29, 2025

[Model Request] GLM-4.5(a SOTA MoE model) mlc-ai/mlc-llm#3295

Open

ddh0 mentioned this pull request Jul 30, 2025

model: Add support for GLM 4.5 family of models (#14921) ggml-org/llama.cpp#14939

Merged

This was referenced Sep 6, 2025

feat: implemented sampling for MTP F1LM1/llama.cpp#1

Merged

feat: Enable multi-token drafting for GLM-4.5 MTP F1LM1/llama.cpp#2

Closed

marksverdhei mentioned this pull request Jan 19, 2026

fix: Add glm4_moe_lite to MLA detection #32614

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

GLM-4.5 Model Support#20736

GLM-4.5 Model Support#20736
Isotr0py merged 53 commits into
vllm-project:mainfrom
zRzRzRzRzRzRzR:glm-moe

zRzRzRzRzRzRzR commented Jul 10, 2025

Uh oh!

github-actions Bot commented Jul 10, 2025

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeejeelee left a comment

Uh oh!

Uh oh!

zRzRzRzRzRzRzR commented Jul 11, 2025

Uh oh!

jeejeelee commented Jul 12, 2025

Uh oh!

zRzRzRzRzRzRzR commented Jul 13, 2025

Uh oh!

zchen-gitch commented Aug 1, 2025

Uh oh!

fernandaspets commented Aug 2, 2025

Uh oh!

fernandaspets commented Aug 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

zRzRzRzRzRzRzR commented Jul 10, 2025

Uh oh!

github-actions Bot commented Jul 10, 2025

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeejeelee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zRzRzRzRzRzRzR commented Jul 11, 2025

Uh oh!

jeejeelee commented Jul 12, 2025

Uh oh!

zRzRzRzRzRzRzR commented Jul 13, 2025

Uh oh!

zchen-gitch commented Aug 1, 2025

Uh oh!

fernandaspets commented Aug 2, 2025

Uh oh!

fernandaspets commented Aug 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants